From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] soc: qcom: socinfo: Add IDs for QCM2290/QRB2210
Date: Wed, 15 Mar 2023 11:14:43 +0100 [thread overview]
Message-ID: <0c5a265f-5394-7088-dd57-c754c68a8554@linaro.org> (raw)
In-Reply-To: <4bbc4411-033c-80ab-39b5-b3059ab77ec6@linaro.org>
On 15.03.2023 07:43, Krzysztof Kozlowski wrote:
> On 14/03/2023 22:41, Konrad Dybcio wrote:
>> Add the missing IDs for scuba and its QRB variant.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> drivers/soc/qcom/socinfo.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>> index e9012ca1a87b..dfc0fc3e90ca 100644
>> --- a/drivers/soc/qcom/socinfo.c
>> +++ b/drivers/soc/qcom/socinfo.c
>> @@ -424,11 +424,13 @@ static const struct soc_id soc_id[] = {
>> { qcom_board_id(SC7180) },
>> { qcom_board_id(SM6350) },
>> { qcom_board_id(QCM2150) },
>> + { qcom_board_id(QCM2290) },
>> { qcom_board_id(SDA429W) },
>> { qcom_board_id(SM8350) },
>> { qcom_board_id(SM6115) },
>> { qcom_board_id(SC8280XP) },
>> { qcom_board_id(IPQ6005) },
>> + { qcom_board_id(QRB2210) },
>
> These should have the same order as defines, so something is here incorrect.
Right, I didn't give it much thought and just added them alphabetically-ish.
I'll fix it right away!
Konrad
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2023-03-15 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 21:41 [PATCH 0/2] QCM2290 socinfo Konrad Dybcio
2023-03-14 21:41 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for QCM2290/QRB2210 Konrad Dybcio
2023-03-15 6:43 ` Krzysztof Kozlowski
2023-03-14 21:41 ` [PATCH 2/2] soc: qcom: socinfo: " Konrad Dybcio
2023-03-15 6:43 ` Krzysztof Kozlowski
2023-03-15 10:14 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c5a265f-5394-7088-dd57-c754c68a8554@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®