From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35CF44052BB for ; Wed, 2 Sep 2026 08:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338945; cv=none; b=h7O8wydUDO8oao/GXwgrcgwVmkq1V5vkT5NPk+SheUwemMF1azE3E26dldvtYJXhcr/saoMS7Ur8c3TxgyqeNEuo3Uh8CDYFW3IHpRgGWwnEeT3f+afxEZ6YyTf1Z18yApNOnyaKN1Bwxs3HCar45VB9j3n5DKTgXKC//+rJEVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788338945; c=relaxed/simple; bh=ss5xROj8OM3lYj+pqG6TTIF5SBt62U9/oUBoQLswgBg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DJcLdouSrLZX8/r0GKTwvGCSoHCSS13quafEaWTGEGhS+YtYygeP1tAnnsGnDVadkhsLlVCz0si+xYRjaE5j3BbEer5E/bJZJHb15OlsA9B+UiArhZLj936sGHyC1zhXomuvpr+VvOoyFbroKF1JJu78uvo1pztbvGvUTj0C+CM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FRGhUyVe; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FRGhUyVe" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-6a6868f18aeso662977a12.0 for ; Wed, 02 Sep 2026 01:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788338942; x=1788943742; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f7aqc1YiIFFi2S/7+a4K7uWSUn18PjZkaszy4zjXDoY=; b=FRGhUyVeZHhqIQy7V+2OH9vwODwXTRs47UnHugrTgp+LSOzcThFqsRm2bSfBJMwhBk 199eI9nSLNaLiHNvQEMwpmT0gpKbAzwHhN7wqzLBlykqSHwCMXCrF6cXhYR3fiC0tX72 2J9XYkRWq68ZDFW4+MxdKrdDPS2FRzLnZuskT7IirKoyI8ysnZNo46D72xxdOyz5EDnD 0H3JcRfYn/vmWl59ZTXEHfOeLzzb4ELjTwLPeyyKnk7w8uBlCJtOSvytm6rAy+1f6Xe7 VxRrKYJrF4GcM2ZVCIp+gNMeEUCF4h7Wpu5MCZhU6mYcXgR5UdXplfMT1J+mZOP9DuVa AjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788338942; x=1788943742; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f7aqc1YiIFFi2S/7+a4K7uWSUn18PjZkaszy4zjXDoY=; b=FARmQMyx1IS6IlDlZ50D1i9hStzmqtCFTM34pwckC9HTGBh6b19uwMnY/uGaPMwIVw 5UugNAwsZN/EETI9P62rO4Ky2QI52m02ets2QjKBs6Cr9B8jdsOo7YBlK3CcU4lcly2P yg0ATyOiBbC45OYR4qRDpjqzI5lFHvQJCSfqa1QfY+yIn1Bo7JQSt9AdofpJqUEvcxAC g+fgLOwMVYyNLaNuvoT+nSng/NgslB1sDDnxkofNd2WjQy4PSdFYf/bjY/FJ9tNx5EKG jbGXlpD6HTirinZbK9ulMLUv+BiZc1NDISQwlh4GLbnFQv/swYckKhaLjXDX4zcMiqim vNaQ== X-Forwarded-Encrypted: i=1; AKwUvBxA6BpnV76hvPIN6D0MgJEDkxBe5bVtOCNL3hkmvaXgxgh8uMd1T2XGvjZXAMZC+Y7Gcw/vCtJOeyr3N9s=@vger.kernel.org X-Gm-Message-State: AFuF++msTtkWus8agbCONdE1RqqioR3f+qknaKDDA4GoQOP2aUK2sZYi l3CVXqzLikZ1bd1Io7dyY0COxdnBPzGbx700pkMczpum07EVn/oojWAO X-Gm-Gg: AYBFou0FPFRA2wEm5BUrhZoHSk7yhM9Kuq/1PIEuPVP2kVD8HSbI6bn8C9d5Zr+aHOA y99GPTNWc7PgV6QG6UnfD9Qm7XR/Pi5zP8GQ/gb7iO1Eulcud0r9cMvsC3htg/CiK00TILxFGiK R6MSAkmqx8NwfSEcJCiGvDTCh4+C9KgdiXkAMFUNCJY6mOOfkzY4oyfO3+ovpO2CyZr1pnR68SQ OV5kSPAoNr4dXUc+HYslIDFPvEIkWt65r8jubbdtGk8oIX1sw0b/NdPI8G9QNgtzFdrXSp25c3j FfmaMEiEMqd/EibCVBYEHyV/sGH7RUn+Gnixp8b1vwxhpm95E1YCoxlk0uix9atDreMiTKxHmhY brdyS1j9tlaJDzHHzAOAFEuaRRTPeSOk565eGPa8+v3UbFED4rTGLywUrAB3JrwHkCVgURsSo0a v/IkeJQx2NansJlEW17E2rrXWQzcayWGzo/a0GE8D8c2QhXW5c+9Kd1o4mOuvhH5rLIIIy8O6up giR6pGhcdCzM8PVTkrwYNuw1w== X-Received: by 2002:a05:6402:21d4:b0:6a3:f63a:4997 with SMTP id 4fb4d7f45d1cf-6a682567131mr2048216a12.3.1788338942157; Wed, 02 Sep 2026 01:49:02 -0700 (PDT) Received: from [172.24.138.145] ([137.71.226.102]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a67f895f29sm764636a12.2.2026.09.02.01.48.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2026 01:49:01 -0700 (PDT) Message-ID: <0c5a657d-e134-49a7-b2cd-82f293685cb7@gmail.com> Date: Wed, 2 Sep 2026 10:48:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support To: Jonathan Cameron , Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , Mark Brown , Marius Cristea , Marcus Folkesson , Kent Gustavsson , Conor Dooley , Daire McNamara , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-spi@vger.kernel.org, Kent Gustavsson , linux-riscv@lists.infradead.org References: <20260827-ad5529r-driver-v10-0-38f2be07b824@analog.com> <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> <178813261957.2788519.4929586195765891569.b4-review@b4> Content-Language: en-US From: Janani Sunil In-Reply-To: <178813261957.2788519.4929586195765891569.b4-review@b4> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/31/26 01:30, Jonathan Cameron wrote: >> >> diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile >> index 992f8930f95c..8dc644522b1e 100644 >> --- a/drivers/iio/dac/Makefile >> +++ b/drivers/iio/dac/Makefile >> @@ -18,6 +18,7 @@ obj-$(CONFIG_AD5446) += ad5446.o >> obj-$(CONFIG_AD5446_SPI) += ad5446-spi.o >> obj-$(CONFIG_AD5446_I2C) += ad5446-i2c.o >> obj-$(CONFIG_AD5449) += ad5449.o >> +obj-$(CONFIG_AD5529R) += ad5529r.o >> obj-$(CONFIG_AD5592R_BASE) += ad5592r-base.o >> obj-$(CONFIG_AD5592R) += ad5592r.o >> obj-$(CONFIG_AD5593R) += ad5593r.o >> diff --git a/drivers/iio/dac/ad5529r.c b/drivers/iio/dac/ad5529r.c >> new file mode 100644 >> index 000000000000..52601cbf28d5 >> --- /dev/null >> +++ b/drivers/iio/dac/ad5529r.c >> @@ -0,0 +1,536 @@ > Why do we need those outer () ? > > ... The outer parenthesis are required by checkpatch for macros with complex values. The same pattern is also used by AD3552R_CH_DAC() in drivers/iio/dac/ad3552r.c -Jan