mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: david@ixit.cz, Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH v2] media: qcom: camss: Don't reject sensor links faster than 4x the CSIPHY timer
Date: Mon, 14 Sep 2026 11:58:08 +0100	[thread overview]
Message-ID: <0c5c7e2b-0dba-4098-8a3a-7ba66adaf108@linaro.org> (raw)
In-Reply-To: <20260914-csiphy-sdm845-limits-v2-1-622db5a6ebf0@ixit.cz>

On 13/09/2026 23:04, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> The timer clock has no such relationship to the link rate. Both the 2ph
> and 3ph code use it only as the reference for csiphy_settle_cnt_calc(),
> where a faster link makes the settle count smaller, not larger: at
> 269.33 MHz the count converges to 16 as the link rate grows. The vendor
> driver pins the timer to 269.33 MHz for every sensor (it is the highest
> rate in the SDM845 clock plan) and streams this exact link with it.
> 
> Clamp to the highest listed rate instead of failing, the same way the
> unknown-link-rate case is already handled.
> 
> Solves issue on sdm845 that caps the link at ~1.02 GHz,
> so the Samsung S5K2X7SP, ~2.3 Gbps/lane, link 1.15 GHz) fails with
> Pixel clock is too high for CSIPHY
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Tested on SHIFT 6MQ with sdm845-next-20260820-9.
> ---
> Changes in v2:
> - Drop the camcc change entirely; the 269.33 MHz ceiling stands. (Konrad)
> - Fix the check in camss instead: clamp the timer clock to the highest
>    listed rate rather than failing, matching the vendor driver.
> - Link to v1: https://patch.msgid.link/20260822-csiphy-sdm845-limits-v1-1-d360bf7cd38f@ixit.cz
> ---
>   drivers/media/platform/qcom/camss/camss-csiphy.c | 16 +++++++---------
>   1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c
> index 539ac4888b608..f3d17ea0ab515 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c
> @@ -157,25 +157,23 @@ static int csiphy_set_clock_rates(struct csiphy_device *csiphy)
>   			long round_rate;
>   
>   			camss_add_clock_margin(&min_rate);
>   
>   			for (j = 0; j < clock->nfreqs; j++)
>   				if (min_rate < clock->freq[j])
>   					break;
>   
> -			if (j == clock->nfreqs) {
> -				dev_err(dev,
> -					"Pixel clock is too high for CSIPHY\n");
> -				return -EINVAL;
> -			}
> -
> -			/* if sensor pixel clock is not available */
> -			/* set highest possible CSIPHY clock rate */
> -			if (min_rate == 0)
> +			/*
> +			 * The timer clock is only the reference for the
> +			 * settle count and does not need to track the link
> +			 * rate. Use the highest listed rate when the link is
> +			 * faster than the table covers or unknown.`
> +			 */
> +			if (j == clock->nfreqs || min_rate == 0)
>   				j = clock->nfreqs - 1;
>   
>   			round_rate = clk_round_rate(clock->clk, clock->freq[j]);
>   			if (round_rate < 0) {
>   				dev_err(dev, "clk round rate failed: %ld\n",
>   					round_rate);
>   				return -EINVAL;
>   			}
> 
> ---
> base-commit: 7079a12d7506b07fb53b54a664bfad5fa9b16d70
> change-id: 20260822-csiphy-sdm845-limits-b1e3dbaf5d38
> 
> Best regards,
> --
> David Heidelberg <david@ixit.cz>
> 
> 
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

      reply	other threads:[~2026-09-14 10:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 22:04 David Heidelberg via B4 Relay
2026-09-14 10:58 ` Bryan O'Donoghue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c5c7e2b-0dba-4098-8a3a-7ba66adaf108@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=andersson@kernel.org \
    --cc=david@ixit.cz \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®