From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4664C433E0 for ; Fri, 5 Feb 2021 06:01:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78C5B60230 for ; Fri, 5 Feb 2021 06:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230395AbhBEGBL (ORCPT ); Fri, 5 Feb 2021 01:01:11 -0500 Received: from smtprelay0219.hostedemail.com ([216.40.44.219]:33568 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230379AbhBEGA7 (ORCPT ); Fri, 5 Feb 2021 01:00:59 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 3255B182CED2A; Fri, 5 Feb 2021 06:00:17 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: song61_3716dc4275e2 X-Filterd-Recvd-Size: 1998 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Fri, 5 Feb 2021 06:00:16 +0000 (UTC) Message-ID: <0c62fcfacca67bfef2275040da7150602fd2003a.camel@perches.com> Subject: Re: [PATCH v2 1/3] fs/efs: Use correct brace styling for statements From: Joe Perches To: Amy Parker , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org Date: Thu, 04 Feb 2021 22:00:13 -0800 In-Reply-To: <20210205051429.553657-2-enbyamy@gmail.com> References: <20210205051429.553657-1-enbyamy@gmail.com> <20210205051429.553657-2-enbyamy@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-02-04 at 21:14 -0800, Amy Parker wrote: > Many single-line statements have unnecessary braces, and some statement > pairs have mismatched braces. This is a clear violation of the kernel > style guide, which mandates that single line statements have no braces > and that pairs with at least one multi-line block maintain their braces. > > This patch fixes these style violations. Single-line statements that > have braces have had their braces stripped. Pair single-line statements > have been formatted per the style guide. Pair mixed-line statements have > had their braces updated to conform. > > Signed-off-by: Amy Parker > --- >  fs/efs/inode.c | 10 ++++++---- >  fs/efs/super.c | 15 ++++++--------- >  2 files changed, 12 insertions(+), 13 deletions(-) > > diff --git a/fs/efs/inode.c b/fs/efs/inode.c > @@ -120,8 +120,10 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino) >   device = 0; >   else >   device = MKDEV(sysv_major(rdev), sysv_minor(rdev)); > - } else > + } > + else { Not the kernel specified style. } else { Try using checkpatch on your proposed patches.