From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Herve Codina <herve.codina@bootlin.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Wojciech Ziemba <wojciech.ziemba@intel.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v6 10/13] iio: inkern: Add a helper to query an available minimum raw value
Date: Tue, 27 Jun 2023 09:58:32 +0000 [thread overview]
Message-ID: <0c6533ce-edad-5b41-c033-b1a0641272f8@csgroup.eu> (raw)
In-Reply-To: <20230623085830.749991-11-herve.codina@bootlin.com>
Le 23/06/2023 à 10:58, Herve Codina a écrit :
> A helper, iio_read_max_channel_raw() exists to read the available
> maximum raw value of a channel but nothing similar exists to read the
> available minimum raw value.
>
> This new helper, iio_read_min_channel_raw(), fills the hole and can be
> used for reading the available minimum raw value of a channel.
> It is fully based on the existing iio_read_max_channel_raw().
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> drivers/iio/inkern.c | 63 ++++++++++++++++++++++++++++++++++++
> include/linux/iio/consumer.h | 12 +++++++
> 2 files changed, 75 insertions(+)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index 19ddd77adb11..7a1f6713318a 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -909,6 +909,69 @@ int iio_read_max_channel_raw(struct iio_channel *chan, int *val)
> }
> EXPORT_SYMBOL_GPL(iio_read_max_channel_raw);
>
> +static int iio_channel_read_min(struct iio_channel *chan,
> + int *val, int *val2, int *type,
> + enum iio_chan_info_enum info)
> +{
> + const int *vals;
> + int length;
> + int ret;
> +
> + ret = iio_channel_read_avail(chan, &vals, type, &length, info);
> + if (ret < 0)
> + return ret;
> +
> + switch (ret) {
> + case IIO_AVAIL_RANGE:
> + switch (*type) {
> + case IIO_VAL_INT:
> + *val = vals[0];
> + break;
> + default:
> + *val = vals[0];
> + if (val2)
> + *val2 = vals[1];
> + }
> + return 0;
> +
> + case IIO_AVAIL_LIST:
> + if (length <= 0)
> + return -EINVAL;
> + switch (*type) {
> + case IIO_VAL_INT:
> + *val = min_array(vals, length);
> + break;
> + default:
> + /* TODO: learn about min for other iio values */
> + return -EINVAL;
> + }
> + return 0;
> +
> + default:
> + return -EINVAL;
> + }
> +}
> +
> +int iio_read_min_channel_raw(struct iio_channel *chan, int *val)
> +{
> + struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(chan->indio_dev);
> + int ret;
> + int type;
> +
> + mutex_lock(&iio_dev_opaque->info_exist_lock);
> + if (!chan->indio_dev->info) {
> + ret = -ENODEV;
> + goto err_unlock;
> + }
> +
> + ret = iio_channel_read_min(chan, val, NULL, &type, IIO_CHAN_INFO_RAW);
> +err_unlock:
> + mutex_unlock(&iio_dev_opaque->info_exist_lock);
> +
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(iio_read_min_channel_raw);
> +
> int iio_get_channel_type(struct iio_channel *chan, enum iio_chan_type *type)
> {
> struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(chan->indio_dev);
> diff --git a/include/linux/iio/consumer.h b/include/linux/iio/consumer.h
> index f536820b9cf2..e9910b41d48e 100644
> --- a/include/linux/iio/consumer.h
> +++ b/include/linux/iio/consumer.h
> @@ -301,6 +301,18 @@ int iio_write_channel_raw(struct iio_channel *chan, int val);
> */
> int iio_read_max_channel_raw(struct iio_channel *chan, int *val);
>
> +/**
> + * iio_read_min_channel_raw() - read minimum available raw value from a given
> + * channel, i.e. the minimum possible value.
> + * @chan: The channel being queried.
> + * @val: Value read back.
> + *
> + * Note, if standard units are required, raw reads from iio channels
> + * need the offset (default 0) and scale (default 1) to be applied
> + * as (raw + offset) * scale.
> + */
> +int iio_read_min_channel_raw(struct iio_channel *chan, int *val);
> +
> /**
> * iio_read_avail_channel_raw() - read available raw values from a given channel
> * @chan: The channel being queried.
next prev parent reply other threads:[~2023-06-27 10:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 8:58 [PATCH v6 00/13] Add support for IIO devices in ASoC Herve Codina
2023-06-23 8:58 ` [PATCH v6 01/13] ASoC: dt-bindings: Add audio-iio-aux Herve Codina
2023-06-27 9:53 ` Christophe Leroy
2023-06-27 9:54 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 02/13] ASoC: dt-bindings: simple-card: Add additional-devs subnode Herve Codina
2023-06-27 9:53 ` Christophe Leroy
2023-06-27 9:54 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 03/13] iio: inkern: Check error explicitly in iio_channel_read_max() Herve Codina
2023-06-27 9:54 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 04/13] iio: consumer.h: Fix raw values documentation notes Herve Codina
2023-06-27 9:55 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 05/13] iio: inkern: Remove the 'unused' variable usage in iio_channel_read_max() Herve Codina
2023-06-27 9:56 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 06/13] iio: inkern: Fix headers inclusion order Herve Codina
2023-06-27 9:56 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 07/13] minmax: Introduce {min,max}_array() Herve Codina
2023-06-27 9:57 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 08/13] iio: inkern: Use max_array() to get the maximum value from an array Herve Codina
2023-06-27 9:57 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 09/13] iio: inkern: Replace a FIXME comment by a TODO one Herve Codina
2023-06-27 9:57 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 10/13] iio: inkern: Add a helper to query an available minimum raw value Herve Codina
2023-06-27 9:58 ` Christophe Leroy [this message]
2023-06-23 8:58 ` [PATCH v6 11/13] ASoC: soc-dapm.h: Convert macros to return a compound literal Herve Codina
2023-06-27 10:00 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 12/13] ASoC: codecs: Add support for the generic IIO auxiliary devices Herve Codina
2023-06-27 10:01 ` Christophe Leroy
2023-06-23 8:58 ` [PATCH v6 13/13] ASoC: simple-card: Handle additional devices Herve Codina
2023-06-27 10:02 ` Christophe Leroy
2023-07-12 11:46 ` [PATCH v6 00/13] Add support for IIO devices in ASoC Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c6533ce-edad-5b41-c033-b1a0641272f8@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=Jonathan.Cameron@huawei.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
--cc=wojciech.ziemba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®