From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753104AbdLHQn3 (ORCPT ); Fri, 8 Dec 2017 11:43:29 -0500 Received: from mout.web.de ([212.227.15.14]:55247 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752050AbdLHQn0 (ORCPT ); Fri, 8 Dec 2017 11:43:26 -0500 To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] serial: sc16is7xx: Delete an error message for a failed memory allocation in sc16is7xx_probe() Message-ID: <0c66b1b0-e715-b4ca-9b64-4a950d62b2b8@users.sourceforge.net> Date: Fri, 8 Dec 2017 17:42:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eQ25e8d89inLuGL4KMwqok0h121WAEDYjJnuCuaPFCzf6/FrHt+ UWRG0pDgJlYB4LmDlVzyggVYUpUZdDZiAoIwxKbixrJgC77aBPuxS+3WjxBWmj5szX/6vJq 6kGZh5UyWax5zlhILXXTQt3VemoOC0/1yz811/Bj7wr7HF8pb099b9+o/yBtMzMKTFxLDxt s+O/l3c1mNqpJDzIkPx6w== X-UI-Out-Filterresults: notjunk:1;V01:K0:lZRp41V3UcY=:ZK+CgVs4oJdpR3yBjSgN3c EgahLhzSQU7+IRiE+zIsq2vg7x/jzLv8F2NzxvEPSJp9EkRl+5bwc3pa4bBWLzol7FGIX0XHG wrtBCBzBIBeVeWVfZ7Ms+7j/+y1BFzMx5Zdr8az1IBlYdgROmwVefgQQAT9DTOkberVLVjUYh B4qxDAcuIe91tcWeRbT4k2bclgW2XIl3hI4rth8QDRtzgxV9JY3XTqMq14DV9n84GiTP1z2+/ yrhixjSWcJr5CbNSwiVVVJWHlDuJQ/NpTGOc9Ty5cygfSaBTS3SqEb65DWE3+g6yz/dVomvLY gF5Ub79ruKxNMebMkDMZIsHCx78gAdnodEDXWpxzYy50Jk5OukP3dB07DM9yw7aY2Sz3Oji+F Gv63asW+3qIWxnwFPVNWXKraNdQKb50VXIG46Lcovo9OQvH8JUnSd8Vlxj0ltTwg7LBFYauTZ gh/gAtL/opUA/cS8pGLWrdVLdXp0REdVpjLOyCqKFyx8vjx6g8SYmXPCbVQWSO85uRwC6QxLA bJD7C6Rqw1sHn55MRWJSIxz0cBN7B7oyXwkHZWNeYzJQoZHsVUUSyOtjao5O8cz9v6NsXZ2Ln 5+Bqyvyq9ZTuijTdMWRy139Pxugwx1JasIbBr/imSENxLYIXT8uUdF+gHkTTr8JALNIvFR+Ub MyI34bl/wBa1MuA2A9A88iDcA8uj3INpmIlH98kq1jEV25hdsCWROb/ni8JX+aJBkGq4VmndT NWxNk1H1k5PEJmkpHKIZ2Ce4dOKMvqY/82WHtC2yDp1VeUa0uHPnYPYOcOlPIZwel/pdriNWL C4JYOc9yO3+vCi0H19DPnhXXPw55sR9hihBboVPJJjY0K/FfXY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 8 Dec 2017 17:27:50 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/sc16is7xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 65792a3539d0..8b3c35f77e7c 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1156,10 +1156,8 @@ static int sc16is7xx_probe(struct device *dev, s = devm_kzalloc(dev, sizeof(*s) + sizeof(struct sc16is7xx_one) * devtype->nr_uart, GFP_KERNEL); - if (!s) { - dev_err(dev, "Error allocating port structure\n"); + if (!s) return -ENOMEM; - } s->clk = devm_clk_get(dev, NULL); if (IS_ERR(s->clk)) { -- 2.15.1