From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969948AbdD3THU (ORCPT ); Sun, 30 Apr 2017 15:07:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45906 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967877AbdD3THN (ORCPT ); Sun, 30 Apr 2017 15:07:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BEDC680462 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BEDC680462 Subject: Re: [PATCH] staging: rtl8723bs: declare private function as static To: Kenneth Hsu , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org References: <20170423173702.GA5842@lenny.localdomain> From: Hans de Goede Message-ID: <0c6c0fed-d0c6-381f-7be0-af32cc5efcd9@redhat.com> Date: Sun, 30 Apr 2017 21:07:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170423173702.GA5842@lenny.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sun, 30 Apr 2017 19:07:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 23-04-17 19:37, Kenneth Hsu wrote: > This fixes a sparse warning regarding an undeclared symbol. Since the > function is private to rtw_recv.c, it should be declared as static. > > Signed-off-by: Kenneth Hsu Looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c > index 74e11948c015..695a5c958c80 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c > @@ -1717,7 +1717,8 @@ sint wlanhdr_to_ethhdr(union recv_frame *precvframe) > } > > /* perform defrag */ > -union recv_frame *recvframe_defrag(struct adapter *adapter, struct __queue *defrag_q) > +static union recv_frame *recvframe_defrag(struct adapter *adapter, > + struct __queue *defrag_q) > { > struct list_head *plist, *phead; > u8 *data, wlanhdr_offset; >