From: Florian Fainelli <f.fainelli@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Pantelis Antoniou <panto@antoniou-consulting.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH] of: Export of_node_ktype for modular use of of_init_node
Date: Fri, 21 Aug 2020 15:01:27 -0700 [thread overview]
Message-ID: <0c705b54-daa1-6f36-b6d2-cd003a75198c@gmail.com> (raw)
In-Reply-To: <CAL_JsqJQuBjNio37Mc1VPxmE-15Sy9qymR-T36=8wOOeoMYPgQ@mail.gmail.com>
On 8/21/20 3:00 PM, Rob Herring wrote:
> On Thu, Aug 20, 2020 at 5:31 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>> To permit the use of of_init_node() by kernel modules, we must export
>> of_node_ktype which is directly referenced by kobject_init() called from
>> of_init_node() otherwise modules would be getting linking failures.
>
> You mean of_node_init()?
Yes, I kept inverting the two words.
>
> There's not anything in the kernel using this that's a module. It's a
> low level function that I don't really want to see more users for.
OK, fair enough, the candidate use I had in mind is probably too ugly to
be submitted upstream anyway.
--
Florian
prev parent reply other threads:[~2020-08-21 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 23:31 Florian Fainelli
2020-08-21 22:00 ` Rob Herring
2020-08-21 22:01 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c705b54-daa1-6f36-b6d2-cd003a75198c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=panto@antoniou-consulting.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®