From: Thomas Zimmermann <tzimmermann@suse.de>
To: WangYuli <wangyuli@uniontech.com>,
alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@gmail.com, simona@ffwll.ch,
sunil.khatri@amd.com, vitaly.prosyak@amd.com,
yifan1.zhang@amd.com, Tim.Huang@amd.com, jesse.zhang@amd.com,
Prike.Liang@amd.com, Hawking.Zhang@amd.com,
kevinyang.wang@amd.com, srinivasan.shanmugam@amd.com,
Jiadong.Zhu@amd.com, tao.zhou1@amd.com, pavel@ucw.cz,
lee@kernel.org, aren@peacevolution.org
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
le.ma@amd.com, Wenhui.Sheng@amd.com, jjhiblot@traphandler.com,
guanwentao@uniontech.com, zhanjun@uniontech.com
Subject: Re: [PATCH] treewide: Correct the typo 'acccess'
Date: Thu, 19 Sep 2024 20:58:03 +0200 [thread overview]
Message-ID: <0c768bf6-bc19-43de-a30b-ff5e3ddfd0b3@suse.de> (raw)
In-Reply-To: <4AB1F900B5D100C2+20240919182855.85840-1-wangyuli@uniontech.com>
Hi
Am 19.09.24 um 20:28 schrieb WangYuli:
> There are some spelling mistakes of 'acccess' in comments which
> should be instead of 'access'.
>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 +-
> drivers/leds/rgb/leds-group-multicolor.c | 2 +-
I think it's better to make 2 patches: one for amdgpu and one for leds.
Each patch can then go into the correct tree.
If you make 2 patches, you can add
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
to each of them.
Best regards
Thomas
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index d3e8be82a172..f847a9fc61e1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -1894,7 +1894,7 @@ static void gfx_v11_0_init_compute_vmid(struct amdgpu_device *adev)
> mutex_unlock(&adev->srbm_mutex);
>
> /* Initialize all compute VMIDs to have no GDS, GWS, or OA
> - acccess. These should be enabled by FW for target VMIDs. */
> + access. These should be enabled by FW for target VMIDs. */
> for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) {
> WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_BASE, 2 * i, 0);
> WREG32_SOC15_OFFSET(GC, 0, regGDS_VMID0_SIZE, 2 * i, 0);
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> index 408e5600bb61..13dca7377f53 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -1248,7 +1248,7 @@ static void gfx_v9_4_3_xcc_init_compute_vmid(struct amdgpu_device *adev,
> mutex_unlock(&adev->srbm_mutex);
>
> /* Initialize all compute VMIDs to have no GDS, GWS, or OA
> - acccess. These should be enabled by FW for target VMIDs. */
> + access. These should be enabled by FW for target VMIDs. */
> for (i = adev->vm_manager.first_kfd_vmid; i < AMDGPU_NUM_VMID; i++) {
> WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_BASE, 2 * i, 0);
> WREG32_SOC15_OFFSET(GC, GET_INST(GC, xcc_id), regGDS_VMID0_SIZE, 2 * i, 0);
> diff --git a/drivers/leds/rgb/leds-group-multicolor.c b/drivers/leds/rgb/leds-group-multicolor.c
> index b6c7679015fd..548c7dd63ba1 100644
> --- a/drivers/leds/rgb/leds-group-multicolor.c
> +++ b/drivers/leds/rgb/leds-group-multicolor.c
> @@ -55,7 +55,7 @@ static void restore_sysfs_write_access(void *data)
> {
> struct led_classdev *led_cdev = data;
>
> - /* Restore the write acccess to the LED */
> + /* Restore the write access to the LED */
> mutex_lock(&led_cdev->led_access);
> led_sysfs_enable(led_cdev);
> mutex_unlock(&led_cdev->led_access);
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2024-09-19 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 18:28 WangYuli
2024-09-19 18:58 ` Thomas Zimmermann [this message]
2024-09-20 3:21 ` WangYuli
2024-09-19 19:01 ` Christian König
2024-09-20 2:31 ` WangYuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c768bf6-bc19-43de-a30b-ff5e3ddfd0b3@suse.de \
--to=tzimmermann@suse.de \
--cc=Hawking.Zhang@amd.com \
--cc=Jiadong.Zhu@amd.com \
--cc=Prike.Liang@amd.com \
--cc=Tim.Huang@amd.com \
--cc=Wenhui.Sheng@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aren@peacevolution.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=guanwentao@uniontech.com \
--cc=jesse.zhang@amd.com \
--cc=jjhiblot@traphandler.com \
--cc=kevinyang.wang@amd.com \
--cc=le.ma@amd.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=simona@ffwll.ch \
--cc=srinivasan.shanmugam@amd.com \
--cc=sunil.khatri@amd.com \
--cc=tao.zhou1@amd.com \
--cc=vitaly.prosyak@amd.com \
--cc=wangyuli@uniontech.com \
--cc=yifan1.zhang@amd.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®