From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C956342503 for ; Wed, 18 Feb 2026 18:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771438377; cv=none; b=kSHGOc2tea0d7qxWOISCgDJRh4aQdTmlmLcz4VNVyYMtO1h4mLf2CFipEHlhu713Fcv2rL4wE81tayA1Cgds9HVIH/Nhv3HTAG0STGWInSmqvXCGbn6FDjqUOi5YVgBUBkRutcSr7w3H/yaPFv0GvkTLkVLQcSnECnJLWHJMhXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771438377; c=relaxed/simple; bh=EGCHzAodjFoZy8zwIYBG26zhK2m8hl6yb7/jmJpKo5E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UA99DpIfPPMoyOnGpbxV775R468YP9YcpAsOdsXjjXcN+w6wjgBIVbrjI3P+YHAtX4XPmAqJZ5Q9KT96RUPMAE41wLrkDMnGu4PsrVkd5DRHY8lPUCNO/Z8Coi8lED3VzY4SaBtRDy5uEenRv1udu7Xjsfc8g6tMjVu3/FhYDFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gTLTC/7f; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VcfuAgsp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gTLTC/7f"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VcfuAgsp" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61IDVnpd1046481 for ; Wed, 18 Feb 2026 18:12:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0qxYicnhNGlFLcggiQLI77gWH/Wu7rKIhhyFeimRe+0=; b=gTLTC/7fQg/PpnEg r4+FYne+wtNRoFdRMRBBrB8WmbJQXoxjckho7MPclKtEVybhzONWam5DnUD8tvo6 oaeK9MtZd6//hb0M0GRm42Ew6gvIINmJbn0BaWIgtr+iUmY6gE/RwkfK9guh/WiB k0y2RcyZtBCaJ4oG4QIVqAM8F+zBZRrfaIx/6UtA5yNN5gW+3E+2lPqUPZyTmvO1 G5jwPEenrFxgZrCOfFila1OG3wRsga0EertXx5Hr4Ai5wPhf/tDKEgA2Pi103lwF xqxWD6J23IEJonr4Jh59jde69iE+BBera4+oicBkR0FM8ZuEYEJjsVytEAku8L4v /+vqUw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cded00tgd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Feb 2026 18:12:55 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-354e7e705e3so40629a91.1 for ; Wed, 18 Feb 2026 10:12:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771438374; x=1772043174; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0qxYicnhNGlFLcggiQLI77gWH/Wu7rKIhhyFeimRe+0=; b=VcfuAgspV7dauuXX0eUbQDF9Z9IpN3gpDqXDWjmzmkGgVP1BiVo5IhPE/twkEowLJX fzNUBi7oxaGCRx7opzmm+WSvgKQ53hjZzAiiUJMGcIjRH/LjYI7O7lRVMgk3KaGUUGJn jOtitTdS63timTR4MGQ2zklqKBRKp2D34zg9NvMaVvcaUfPa0WQWWnuR4nUNWVzC6AVL Xe+zuN9hlnJ1xGxLcx9u/v4NAgC0vltQO6qiqGmaT2e3xj7mOnUIR7J8yNheSY7JRr/o iDuNNSPuva1DA42+E/ZnFDuW12C4BSswvL3q1qixku9aIokOQqlVMrKxJ/N1OfPw5OkP JBCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771438374; x=1772043174; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0qxYicnhNGlFLcggiQLI77gWH/Wu7rKIhhyFeimRe+0=; b=iKlclzMJLZmjC+6fovJ+CodyB9OMkkxLvzWVbCpK2SrbAr0PAqPOdTEfYgMXJDS0pP YzXB5DfQvTAw/Z4L49O34zB9NsDxina5mKPBEr9iWFnRfDnW6ksZ4oUeesaSDszIQvLq QbsdecJ84vd04CWpgbHWhTDWLTbfN4oM9bSJGvDM6S6kh/tybgxtqu+o+XWilrs7fn7g FBKO4v3kx445fKekHudSNREKvi3PtZb+5+3LvFQs+AW5T4/A4ECEyv3E7OqL3ZLIqnFT GNgpjAZYmczReyiWtarKnDRsxMTigkTItUbYOUdzkkSJSgOrALwtUABRIZZHwuBtpGZu Siug== X-Forwarded-Encrypted: i=1; AJvYcCVmWNLNSW1ErUY2GV9gzU9Y37ng/338lpWgbGvyxGLR/JB3HXVs38dAPdMGSlX7FCSlzaeQeM+kz8uOt8w=@vger.kernel.org X-Gm-Message-State: AOJu0YzkPVEJDJuxSsZ78eXc8ect+rqVIupGSjAEbsqeIQ/85BH801a1 nco0NuDAuvfNdu30gkrHr4e8hw55HHmhdbFOKIGl4cPBV6TPin+5k4V/O5IfvtaMblnlX3hWkQ4 KVfnavOdBTTulw4hNHXenlRIOxxYKoiTDfJC8JqdEQiMzfMsyWUqIfCRDJWcQ3u+op0M= X-Gm-Gg: AZuq6aI76JJbM7yfHoxqjMykT1aTyzfvQcHlkAIXhD4YrO2RRDs2L0ntn40e1fekJWD R/iJFVtwIY7m60dveG5FP/0hAH9si17g6IMlCa5VJBsfRtQ9/zm2FfmGz79yHeGQ/BMBvc4uPkH YGUGQJYzCImHhkgzjmqho2GQipWQyzT4kJjvGuP9usTatBc/jzbaHxwFBkaBXjGcsBCdeaLEDVQ OW4VNjfphaMUrF/2Q5QH5KwlgzrNyF1cN9reH83++KNt8GFcoyxvDpVAzizC1YEF7OGyTje+gDD i1+3JTwcfPCe7l26BuZ2O4o6sYnHqQ00O6YDBx4t6Q7FJ8hzaZQldg/amVriqordIe1WywRMLWy NIwP4T0xk5a8q64NrmRsif4eYTv5wHFrPJAPTGmxdt46yVTgL3aY= X-Received: by 2002:a17:90b:1348:b0:341:c964:126c with SMTP id 98e67ed59e1d1-3589380276emr130931a91.34.1771438374185; Wed, 18 Feb 2026 10:12:54 -0800 (PST) X-Received: by 2002:a17:90b:1348:b0:341:c964:126c with SMTP id 98e67ed59e1d1-3589380276emr130915a91.34.1771438373715; Wed, 18 Feb 2026 10:12:53 -0800 (PST) Received: from [192.168.29.32] ([49.43.224.102]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35887899158sm1783264a91.5.2026.02.18.10.12.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 10:12:53 -0800 (PST) Message-ID: <0c7a4fef-e7c6-43d9-83ca-65a182a33adf@oss.qualcomm.com> Date: Wed, 18 Feb 2026 23:42:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] Add CAMSS support for SM6350 To: Konrad Dybcio , Luca Weiss , Bryan O'Donoghue , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Taniya Das Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260213-sm6350-camss-v3-0-30a845b0b7cc@fairphone.com> <124c661b-db25-466a-a163-99ca336a3e70@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: <124c661b-db25-466a-a163-99ca336a3e70@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: uuRR8V_-TMmdOPMON9TxeavsqB1Vl_XM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE4MDE1NSBTYWx0ZWRfXw6yZeiOt1m7U HOKbeH6B340c6u5t8QH84MuH9c5BGvsJMH+1AlLLsDdnn1u6pe+d5hbT+imFy23K7bUxspMrxnG IOFOBpLqkl3X80436sR8H89JNPW8OhGYA/fo0R/ONMqqm9huvoLdT6OSjNme81TPAAxQkyZ8Lvi ZzEomctCEMv+IswUAS2UgvC3nEJGTVtzxoBHSPCZvvl36zTt3nh2uvRMISVLjExDTj4r1t0ne8K 0+hWtoRHlUlN1hdDVl7uvFZS1L/tldsDXvMxcjfqdIOQnHQVHGBUdalH8RppyoXpawAYk7AV91D 6HwyMo3KGiwT4mDibDlLQwKSfTflrQn/HrbzuDwsUu4nBJYsndGyXamOIgWO10E+MnkkipVGu0P Bk3AKKEaNYX31Hi7VTOBB5DDkxTrXa/eTQUJhP6VW7/16oD/hDgs4gMSHpUli9N0nNa0nyv9eJs 8YZD9n62A5dnu8k91sg== X-Authority-Analysis: v=2.4 cv=b/q/I9Gx c=1 sm=1 tr=0 ts=69960127 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=8ET0PZbB28S/dExBzKx22g==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=BC0RzjFpySZ26J9PUKwA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: uuRR8V_-TMmdOPMON9TxeavsqB1Vl_XM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_03,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602180155 On 17-02-2026 05:31 pm, Konrad Dybcio wrote: > On 2/17/26 12:56 PM, Imran Shaik wrote: >> >> >> On 16-02-2026 04:34 pm, Konrad Dybcio wrote: >>> On 2/13/26 2:15 PM, Luca Weiss wrote: >>>> Add bindings, driver and dts to support the Camera Subsystem on the >>>> SM6350 SoC. >>>> >>>> These patches were tested on a Fairphone 4 smartphone with WIP sensor >>>> drivers (Sony IMX576 and IMX582), the camera pipeline works properly as >>>> far as I can tell. >>>> >>>> Though when stopping the camera stream, the following clock warning >>>> appears in dmesg. But it does not interfere with any functionality, >>>> starting and stopping the stream works and debugcc is showing 426.4 MHz >>>> while the clock is on, and 'off' while it's off. >>>> >>>> Any suggestion how to fix this, is appreciated. >>>> >>>> [ 5738.590980] ------------[ cut here ]------------ >>>> [ 5738.591009] gcc_camera_axi_clk status stuck at 'on' >>> >>> FWIW 845 has .halt_check = BRANCH_VOTED here, which translates into >>> 'dont check the state at disable', this one has BRANCH_HALT (i.e. spin >>> and keep checking the hw state) >>> >>> +Taniya would BRANCH_VOTED be fitting for 6350 too? ^ >>> >> >> The parent RCG of this clock is under NoC control, and seems like there is no vote on the NoC while disabling this clock, hence this issue is observed. >> >> The BRANCH_HALT_VOTED/BRANCH_HALT_SKIP should help, or if the NoC voting is removed after the clock disable then also this issue should be resolved. > > This is very useful, thanks for the insight! > > Is any of these solutions specifically preferred from your side? > > Konrad From clock controllers side we can use the BRANCH_HALT_SKIP as this covers both enable/disable scenarios. But this needs to be checked further from consumer driver side as well to handle the NoC voting properly. Thanks, Imran