From: "Joseph, Jithu" <jithu.joseph@intel.com>
To: Armin Wolf <W_Armin@gmx.de>, <maurice.ma@intel.com>,
<hdegoede@redhat.com>, <markgross@kernel.org>,
<ilpo.jarvinen@linux.intel.com>
Cc: <Dell.Client.Kernel@dell.com>,
<platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] platform/x86: wmi: Add wmidev_block_set()
Date: Thu, 2 Nov 2023 12:08:12 -0700 [thread overview]
Message-ID: <0c87ab95-1727-4a02-92a3-3e0a14f5b715@intel.com> (raw)
In-Reply-To: <20231102042959.11816-1-W_Armin@gmx.de>
On 11/1/2023 9:29 PM, Armin Wolf wrote:
> Currently, WMI drivers have to use the deprecated GUID-based
> interface when setting data blocks. This prevents those
> drivers from fully moving away from this interface.
>
> Provide wmidev_block_set() so drivers using wmi_set_block() can
> fully migrate to the modern bus-based interface.
>
> Tested with a custom SSDT from the Intel Slim Bootloader project.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/platform/x86/wmi.c | 64 ++++++++++++++++++++------------------
> include/linux/wmi.h | 2 ++
> 2 files changed, 36 insertions(+), 30 deletions(-)
>
I noticed that this patch doesn't apply ontop of the latest released tag (v6.6) (the other 3 applies)
Just a minor suggestion :
Perhaps a note on which tree/base-commit the patch would apply would be helpful for reviewers
(After some digging around I found that the patch does indeed apply ontop of your patches submitted for the merge window)
Jithu
prev parent reply other threads:[~2023-11-02 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 4:29 Armin Wolf
2023-11-02 4:29 ` [PATCH 2/4] platform/x86: wmi: Add to_wmi_device() helper macro Armin Wolf
2023-11-02 4:29 ` [PATCH 3/4] platform/x86: intel-wmi-sbl-fw-update: Use bus-based WMI interface Armin Wolf
2023-11-02 18:49 ` Joseph, Jithu
2023-11-02 4:29 ` [PATCH 4/4] platform/x86/intel/wmi: thunderbolt: " Armin Wolf
2023-11-02 13:28 ` Mario Limonciello
2023-11-02 19:08 ` Joseph, Jithu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c87ab95-1727-4a02-92a3-3e0a14f5b715@intel.com \
--to=jithu.joseph@intel.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=maurice.ma@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®