mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gupta, Pankaj" <pankaj.gupta@amd.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Kiryl Shutsemau <kas@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Lorenzo Stoakes <ljs@kernel.org>, Michal Hocko <mhocko@suse.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/cma: accept memory of multi-range CMA areas
Date: Mon, 2 Nov 2026 15:55:50 +0100	[thread overview]
Message-ID: <0c88652a-0b0a-4092-9c4e-d4db8f89bd74@amd.com> (raw)
In-Reply-To: <auM56dTOXCb70vzz@kernel.org>

>>> On systems with unaccepted memory, memblock allocations accept the
>>> allocated range, but when cma_declare_contiguous_multi() uses open coded
>>> allocation of multiple ranges, it reserves them with memblock_reserve()
>>> and they are never accepted.
>>>
>>> These pages are released to the buddy allocator by cma_activate_area()
>>> with __free_pages() that does not check for unaccepted memory, so the
>>> first access to such a page in a TDX or SEV-SNP guest is fatal.
>>>
>>> Accept the memory of each range when it is reserved.
>> Fix looks correct to me.
>>
>> Any easy way to reproduce and test on SEV SNP?
> I think running a VM with 16G or ram on a single node and with
>
> hugetlb_cma=8G memmap=2M\$0x2ffe00000 init_on_free=1

This triggered an unrelated issue for me, I sent a fix here:

https://lore.kernel.org/all/20261102113127.161823-1-pankaj.gupta@amd.com/

I was able to verify this series with:

hugetlb_cma=8G cma=2G@0x200000000 init_on_free=1

Thanks,

Pankaj


  reply	other threads:[~2026-11-02 14:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 10:18 [PATCH 0/2] mm/cma: accept memory of CMA areas reserved with memblock_reserve() Mike Rapoport (Microsoft)
2026-10-29 10:18 ` [PATCH 1/2] mm/cma: accept memory of multi-range CMA areas Mike Rapoport (Microsoft)
2026-10-29 10:52   ` Gupta, Pankaj
2026-10-29 12:19     ` Mike Rapoport
2026-11-02 14:55       ` Gupta, Pankaj [this message]
2026-10-29 10:18 ` [PATCH 2/2] mm/cma: accept memory of CMA areas reserved at a fixed address Mike Rapoport (Microsoft)
2026-10-29 12:27 ` [PATCH 0/2] mm/cma: accept memory of CMA areas reserved with memblock_reserve() Kiryl Shutsemau
2026-10-29 12:40   ` Mike Rapoport
2026-10-29 13:17     ` Kiryl Shutsemau
2026-10-29 15:03       ` Mike Rapoport
2026-10-29 15:39         ` Kiryl Shutsemau
2026-11-02 14:41 ` Gupta, Pankaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c88652a-0b0a-4092-9c4e-d4db8f89bd74@amd.com \
    --to=pankaj.gupta@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=kas@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®