From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751933AbdJ0Hex (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 03:34:53 -0400
Received: from mout.web.de ([217.72.192.78]:60121 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750930AbdJ0Heu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 03:34:50 -0400
Subject: Re: IB/mlx4: Use common error handling code in
 __mlx4_ib_create_flow()
To: Dennis Dalessandro <dennis.dalessandro@intel.com>,
        linux-rdma@vger.kernel.org
Cc: Doug Ledford <dledford@redhat.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        Leon Romanovsky <leon@kernel.org>, Sean Hefty <sean.hefty@intel.com>,
        Yishai Hadas <yishaih@mellanox.com>,
        Yuval Shaia <yuval.shaia@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <0bcea3cf-91e3-01d5-8d80-34cd6b611fb1@users.sourceforge.net>
 <70843f43-03c5-8295-643a-4f228ff2e907@intel.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <0c92fc8e-ecb8-c7ed-0b4c-721752297222@users.sourceforge.net>
Date: Fri, 27 Oct 2017 09:34:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <70843f43-03c5-8295-643a-4f228ff2e907@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:HfkSAmNksGWycJLl1ibBOSWKg+9gfyMztKBhI3vvE3ETERspTZC
 oWKRFPXBdoOqUCc/snDISHgVl+xnTFFRqfPbliyZiPhrmouzSFp1Sbb0UJlXlMcIkdJgk4n
 U2bUi1nnZim9YkIbvkyT87TkRsZgxm06GeSmbD+E3WV+Ee0Xcy6dztOFq3Nj4NWvt++2i2T
 ZK9BPwku+cXIeLPBAnzeQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:j7GPhGPSdHc=:0eExRBLNaIOm2BFMy8so6M
 WyFTb+nPjInIaHY7eAgO9rzGnhmPRIRfrqhHTmpC5zi7084vPsHAUNzpADlVNpohVbQ9Sb04H
 jOKIycNMSBZTEyCBAZnbSZwtmvVAqoVOv3JVBfmBhFXefgmz+7W0uyZq5LIQ+9Zs7L+aXpw3k
 OWgWyzj4m8CakPCr0Fr+2XSgMwmqlhj1+alfYuMJu43Y50rp4z4X/O8VXe+TnTZ0Vxb8vmdoT
 wD3i22EykxWgrEWDMpcacWMmQZkdccW33emsLz4GeVxxE1J9qU4I7Cz+aK0IzgNjLYk3fGjSj
 70uuUO+hZ84KitZWF13WTmC975/UlFg50Q0YoV57lMRKn9ZiqaW+ktHuzEFvxGgnccSQQhtdP
 VjWnjkxz3IRkFovIlIEuhw6IZcBUCmOkPF3F9o4se+rhbr981aSExSgWXZs5rn0rymUUTC8Ce
 OjPyw15Ixts5e7t6tMzXbkrSIefSZ4B11rFOY2qazGElPuUW/Fx3hbmvRkhSxlSPFmO5YtK73
 U+XI64lH3q+nFCrjWH0QLI9ils5nKdApTdyBNA2VOsQKPlUjRz2GTxZjy83UZUdMGOYMfppzE
 rjK19ynyNdd5z6jym6fEirE5BaISZFYPDnt21fM1QvMFNCsnX8lrz7/sM2b+j3aTsp25gJk1H
 IR3Oo9XuuIiqsjtrqpKeihDDOkb53ND6Il3BrehPrOuGNWIMG8plYo1pQTYgQhKd0MBOyPHyS
 1/6T+Nqmd8LcsV8MfrewOWbksrwIvfUm5tRSjlTwbQai2hm7uuVqJMfHfOe0psEePn0W6kEsc
 GiSvnLEchaESLIfOV05zHrRy6IXYc9/4c1o7JPoLOH1fghJP2A=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
> 
> I'm not sure this is that big of a win.

Such a view is appropriate because I proposed just another small adjustment
for this source code place.


> I mean you aren't really making the code any smaller

Would anybody like to check corresponding effects in more detail
after a specific function call was replaced by a goto statement?


> and it's not making it any easier to read really.

Is the code readability still good enough there?

Regards,
Markus