From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932930AbcIUHwd convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 03:52:33 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:17134 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932754AbcIUHwb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 03:52:31 -0400
X-PGP-Universal: processed;
        by hqnvupgp07.nvidia.com on Wed, 21 Sep 2016 00:46:54 -0700
Subject: Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions
To: Paul Kocialkowski <contact@paulk.fr>, <linux-kernel@vger.kernel.org>
References: <20160828173246.32621-1-contact@paulk.fr>
 <ef69b6d2-ce6b-ff76-5c04-ab2176eb6ecc@nvidia.com>
 <1474395289.1215.20.camel@paulk.fr>
CC: <devicetree@vger.kernel.org>, Stephen Warren <swarren@wwwdotorg.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        <linux-tegra@vger.kernel.org>, Alexandre Courbot <gnurou@gmail.com>,
        <linux-arm-kernel@lists.infradead.org>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <0ca614bf-4d27-9948-03e3-472d059f2153@nvidia.com>
Date: Wed, 21 Sep 2016 08:52:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1474395289.1215.20.camel@paulk.fr>
X-Originating-IP: [10.21.132.118]
X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To
 UKMAIL101.nvidia.com (10.26.138.13)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 20/09/16 19:14, Paul Kocialkowski wrote:
> * PGP Signed by an unknown key
> 
> Le mardi 20 septembre 2016 à 18:15 +0100, Jon Hunter a écrit :
>> On 28/08/16 18:32, Paul Kocialkowski wrote:
>>>
>>> This switches a few interrupt definitions that were using
>>> GPIO_ACTIVE_HIGH as IRQ type, which is invalid.
>>
>> May be you are right, but this does not describe why this is invalid.
>> Can you elaborate?
> 
> GPIO_ACTIVE_HIGH is simply not the right kind of define to use in the
> "interrupts" devicetree property. Values provided there are understood as
> IRQ_TYPE_ defines.

Right, but you are changing the type as GPIO_ACTIVE_HIGH = 0 and
IRQ_TYPE_EDGE_FALLING = 2 and there is no comment about why this has
been changed. It might be correct, but you need to explain it.

Jon

-- 
nvpublic