From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C628242AF9F for ; Mon, 27 Jul 2026 20:31:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184319; cv=none; b=m1ASPyLi1y7XKo/DcCbp7Dg30KMQoIMFpFqbHDOsAzKsuZY0b8BoVaGRBxOykP0wkZqiDAFxxaUOtvFk2ZeyhQvS2IK6P1cZuav6Z9OUcxuPApDi4Wj8oNwKN5ECgemZwIaw6T1GhW7S1zyxGf6MvHevuPHm66tB09JpGzNAYrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184319; c=relaxed/simple; bh=J3VKNEdFAAo+UuM5SW7cLaHeFou73T8tm///APbl6YQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gf0E7oFlg80kdzvodmOIiT2SekSRZhCN0XHATsvC3eFije9/0A9C+tx9trkRsFgYTgdTgSbC+ky9WW69GpfBlxg2QxuP9W1lwvz1zisJMQr/l4F4ad2Hj4eiv86IGJDKIh16JDv5BGpI61R9q4mKYVmUFH3gAU59ADRwahWrtI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ictwz9RY; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ictwz9RY" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cad4170e8eso47750525ad.3 for ; Mon, 27 Jul 2026 13:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785184317; x=1785789117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R1xIi9uEBJJusV1JgfzAtL1JCAhMgUNucNOCrJdZRRo=; b=ictwz9RY10msFctOvi3yLd1yZGg1+OQiqVQvZr5uJDDIhY40O6wjCvzcHMJD86Riqq jWUu71JIeogWjq/af2UyaFrBh445xTOalOi43zm2sWjekZBxZ+GQSPgk8GRK1COAwxYi Cuorxi7vg+HTNpxtCRoK7/wgwYrRRtBC2UjxVfWq6mSB9F+xGP14oju9TFukQ5L8fyWh SMfVWuLe9xm1wXsljEfkOCT4i/7/CqNKYvzHZ81MUiJI+5Uu9b6dU8U1+KrnCcFq3ZRo uOCvBTFfv8s7bFg6aPHJ6oFoXPKr1wwZPEsYczbv6ffzUH7dMblfO0AnIrtP6FnFihtw Imag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785184317; x=1785789117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=R1xIi9uEBJJusV1JgfzAtL1JCAhMgUNucNOCrJdZRRo=; b=S+vESEZ0APvM73X+9lOepaCZ4NmrnxqFFh5Lvz/2gAbLge5dvMTivBf6ts8tuHkz+L P+tF6S8mn11wdKwcQdJOYBt0Y9D+teGd9FfNZ0vL3NFg2T6d9WYwv6re1XbblQW8F/Gb nvf7cqRYD4WGF1zhKC4HG8Vs9Nuttd9opkYmXGe9dByIYklQBwRl5IM6/r2kD+ehRmoZ sHNsospiaV3NuwZed5yswKeIHVHKGbdK7rd6SnvtV/Wry52lEm6R3ZBVMMUzYQmPs8pj N1kFu/9bpIh9Pl5UAxwCH0J3I4uANoXLSh+6i+FFv5e4ps7bxLxh59Cp2qyJMHFBQqMz 2c5g== X-Forwarded-Encrypted: i=1; AHgh+RoAs8zCZA+73RJexAn8MByVe+Q1gj3Mrq1BrADZXaGzIbDVdqa/3LFl1YFktrufiKej+17ssoPtxvXQjk4=@vger.kernel.org X-Gm-Message-State: AOJu0YzPA2jMm+0fujoDn9eXF7OAYyqMUk1MCIBZQzV9QfTDRolhOT6i mkv9z+qnmdHjUvEOdweQaEFGvbvT3Nx4hg04odhnpyWqrzAD0I1LVght X-Gm-Gg: AR+sD12XWndpNdNIOEV2reLNpA1irc1g2Sty77H9JC5HQDs84q3zBrwld0E6M1NK+aW syMA9JG19eP4xCgkmw4lfBQpZAt18/9H2bbjwFigYdBiWYRehLTDjHjWbysjyFyMCovfdCPxuan Wr7rO/fLyL7rK1eoTOCNYIH6BTSxiZWTGBtaFozzlLz+IHQrtz7cjfE9H2p4rGVMaSPGkTWInw7 xv1fzsw0GRrOU2mUBA+F3/iylJE4hoRqNNLlKxqkG0SqIHbMQA9LKAHTol1FYOGtVVnkVqqrBi9 A/G4DyMfsxqzs/AeplVs5Ew7hwtXpz5JqO5Aokc3pnvEVpo4Hx3lYkBa3gC8e3Sgdh+v9Kwvh3g qWLRoSK01YnwDGGdfeOBo6bopKAMLomqhygda3esMYewBROSoIBjjykQhbp9C79WVu6C7xsBFHt gr207l X-Received: by 2002:a17:902:fda8:b0:2ca:c01e:8837 with SMTP id d9443c01a7336-2d00f380107mr7109805ad.24.1785184316966; Mon, 27 Jul 2026 13:31:56 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fab:e200:3789:64f9:8855:c0af]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59b768sm41551805ad.4.2026.07.27.13.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:31:56 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook Subject: [PATCH v2 14/64] dmaengine: nbpfaxi: switch callbacks to dma_chan BH Date: Mon, 27 Jul 2026 13:28:42 -0700 Message-ID: <0ca89b05c6c34edde9745324b832f37f8a12922b.1785183549.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260108080332.2341725-1-allen.lkml@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dma_chan BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/nbpfaxi.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c index 05d7321629cc..aea94451258a 100644 --- a/drivers/dma/nbpfaxi.c +++ b/drivers/dma/nbpfaxi.c @@ -174,7 +174,6 @@ struct nbpf_desc_page { /** * struct nbpf_channel - one DMAC channel * @dma_chan: standard dmaengine channel object - * @tasklet: channel specific tasklet used for callbacks * @base: register address base * @nbpf: DMAC * @name: IRQ name @@ -200,7 +199,6 @@ struct nbpf_desc_page { */ struct nbpf_channel { struct dma_chan dma_chan; - struct tasklet_struct tasklet; void __iomem *base; struct nbpf_device *nbpf; char name[16]; @@ -1125,9 +1123,10 @@ static struct dma_chan *nbpf_of_xlate(struct of_phandle_args *dma_spec, return dchan; } -static void nbpf_chan_tasklet(struct tasklet_struct *t) +static void nbpf_chan_tasklet(struct dma_chan *c) { - struct nbpf_channel *chan = from_tasklet(chan, t, tasklet); + struct nbpf_channel *chan = container_of(c, struct nbpf_channel, + dma_chan); struct nbpf_desc *desc, *tmp; struct dmaengine_desc_callback cb; @@ -1228,7 +1227,7 @@ static irqreturn_t nbpf_chan_irq(int irq, void *dev) spin_unlock(&chan->lock); if (bh) - tasklet_schedule(&chan->tasklet); + dma_chan_schedule_bh(&chan->dma_chan); return ret; } @@ -1272,7 +1271,7 @@ static int nbpf_chan_probe(struct nbpf_device *nbpf, int n) snprintf(chan->name, sizeof(chan->name), "nbpf %d", n); - tasklet_setup(&chan->tasklet, nbpf_chan_tasklet); + dma_chan_init_bh(&chan->dma_chan, nbpf_chan_tasklet); ret = devm_request_irq(dma_dev->dev, chan->irq, nbpf_chan_irq, IRQF_SHARED, chan->name, chan); @@ -1478,7 +1477,7 @@ static void nbpf_remove(struct platform_device *pdev) devm_free_irq(&pdev->dev, chan->irq, chan); - tasklet_kill(&chan->tasklet); + dma_chan_kill_bh(&chan->dma_chan); } of_dma_controller_free(pdev->dev.of_node); -- 2.43.0