From: Markus Elfring <Markus.Elfring@web.de>
To: Abdun Nihaal <abdun.nihaal@gmail.com>,
brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev,
linux-wireless@vger.kernel.org,
Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Jacobe Zang" <jacobe.zang@wesion.com>,
"Jeff Johnson" <jeff.johnson@oss.qualcomm.com>,
"Kalle Valo" <kvalo@kernel.org>, "Ondřej Jirman" <megi@xff.cz>,
"Sai Krishna" <saikrishnag@marvell.com>,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH v2] wifi: brcmfmac: fix memory leak in brcmf_get_module_param
Date: Sun, 30 Mar 2025 14:10:15 +0200 [thread overview]
Message-ID: <0ca9b435-7e5f-4208-a707-c9bf08f815bf@web.de> (raw)
In-Reply-To: <20250330103425.44197-1-abdun.nihaal@gmail.com>
> The memory allocated for settings is not freed when brcmf_of_probe
> fails. Fix that by freeing settings before returning in error path.
failed?
Would you like to append parentheses to any function names?
Regards,
Markus
prev parent reply other threads:[~2025-03-30 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-30 10:34 Abdun Nihaal
2025-03-30 12:10 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ca9b435-7e5f-4208-a707-c9bf08f815bf@web.de \
--to=markus.elfring@web.de \
--cc=abdun.nihaal@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=jacobe.zang@wesion.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=saikrishnag@marvell.com \
--cc=sebastian.reichel@collabora.com \
--cc=toke@toke.dk \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®