From: Jens Axboe <axboe@kernel.dk>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
bfq-iosched@googlegroups.com, oleksandr@natalenko.name,
tschubert@bafh.org, patdung100@gmail.com, cevich@redhat.com
Subject: Re: [PATCH BUGFIX V2 0/1] block, bfq: deschedule empty bfq_queues not referred by any process
Date: Thu, 14 Nov 2019 07:02:09 -0700 [thread overview]
Message-ID: <0cb0a853-e036-9884-5681-f4617de5c662@kernel.dk> (raw)
In-Reply-To: <20191114093311.47877-1-paolo.valente@linaro.org>
On 11/14/19 2:33 AM, Paolo Valente wrote:
> Hi Jens,
> change from V1: added check to correctly work only on bfq-queues
> scheduled for service, and not on in-service bfq-queues (it makes no
> sense, and it creates inconsistencies, to deschedule an in-service
> bfq-queue).
>
> Differently from V1, which was still under test when I submitted it,
> this version has already been tested, by those who reported V1's
> failures.
I'm a bit miffed that you'd send out a patch for an issue, this late
in the cycle, and then it not being tested at all. That's not very
confidence inspiring. I have applied this one, just letting you know
that that is not acceptable at all.
--
Jens Axboe
next prev parent reply other threads:[~2019-11-14 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 9:33 Paolo Valente
2019-11-14 9:33 ` [PATCH BUGFIX V2 1/1] " Paolo Valente
2019-11-15 18:32 ` Holger Hoffstätte
2019-11-15 18:38 ` Jens Axboe
2019-11-14 14:02 ` Jens Axboe [this message]
2019-11-14 15:14 ` [PATCH BUGFIX V2 0/1] " Paolo Valente
2019-11-14 15:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cb0a853-e036-9884-5681-f4617de5c662@kernel.dk \
--to=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=cevich@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
--cc=patdung100@gmail.com \
--cc=tschubert@bafh.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®