From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426AbeAPQli (ORCPT + 1 other); Tue, 16 Jan 2018 11:41:38 -0500 Received: from vern.gendns.com ([206.190.152.46]:41977 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbeAPQla (ORCPT ); Tue, 16 Jan 2018 11:41:30 -0500 Subject: Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks To: Adam Ford , Sekhar Nori Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , linux-kernel@vger.kernel.org References: <1515377863-20358-1-git-send-email-david@lechnology.com> <5aacc350-6236-2e4f-35bb-a681fc9d47e7@ti.com> <40501635-6f5b-20c9-f8bc-d17e26b58426@lechnology.com> <5832fd62-16aa-e167-7e52-2ce493e33cdc@lechnology.com> <8184c7b5-5f82-5590-9caf-fd038e1d07ac@ti.com> From: David Lechner Message-ID: <0cb6058f-3f58-cb76-5769-bee36732fb2c@lechnology.com> Date: Tue, 16 Jan 2018 10:41:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/16/2018 06:21 AM, Adam Ford wrote: > On Tue, Jan 16, 2018 at 5:22 AM, Sekhar Nori wrote: >> Hi Adam, David, >> >> On Friday 12 January 2018 03:04 AM, Adam Ford wrote: >>> Thanks for clarifying. I was able to make it work with the following patch: >>> >>> diff --git a/drivers/clk/davinci/psc-da850.c b/drivers/clk/davinci/psc-da850.c >>> index 3b4583d..a76b8682 100644 >>> --- a/drivers/clk/davinci/psc-da850.c >>> +++ b/drivers/clk/davinci/psc-da850.c >>> @@ -25,7 +25,7 @@ static const struct davinci_psc_clk_info >>> da850_psc0_info[] __initconst = { >>> LPSC(9, 0, uart0, pll0_sysclk2, 0), >>> LPSC(13, 0, pruss, pll0_sysclk2, 0), >>> LPSC(14, 0, arm, pll0_sysclk6, LPSC_ALWAYS_ENABLED), >>> - LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET), >>> + LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET | >>> LPSC_ALWAYS_ENABLED), >> >> Keeping the DSP clock always enabled was not needed earlier AFAICS, so >> this needs to be investigated. > > I was testing the DA850-evm and found it was required or the DA850 > wouldn't boot. I don't know enough of why to explain it. I went > through all the clocks as suggested by David, and this one-line patch > fixed the hanging problem I had. Without it the AM1808 board I have > won't boot. That's interesting because 1) the AM1808 does not have a DSP and 2) I am using an AM1808 based system as well that boots without having this always enabled (AM1808BZWT4 to be exact). I guess I will leave this change out of the next revision so that we don't forget that this needs to be addressed. Sekhar found a bug in the new PSC driver with the LPSC_FORCE bit, so maybe that could be the difference. Adam, before the changes in this series, did you have CONFIG_DAVINCI_RESET_CLOCKS=y in your config?