From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752715AbdLGVTX (ORCPT ); Thu, 7 Dec 2017 16:19:23 -0500 Received: from mout.web.de ([212.227.17.11]:65270 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbdLGVTV (ORCPT ); Thu, 7 Dec 2017 16:19:21 -0500 Subject: [PATCH 1/2] serial: sccnxp: Delete an error message for a failed memory allocation in sccnxp_probe() From: SF Markus Elfring To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org References: <90e7fa7a-c0e6-4819-9fa6-fae1a71685eb@users.sourceforge.net> Message-ID: <0cc41c23-26f9-2102-7fe9-271271b0e8f5@users.sourceforge.net> Date: Thu, 7 Dec 2017 22:19:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <90e7fa7a-c0e6-4819-9fa6-fae1a71685eb@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:TU7Sg0AQjfDn7xvyZ7rh1ZzGFSksN3KKDtODPhfWuCg5e3rhlcI jpw9qJzSh3VQivYlkB4YWbCp1ulnIiVmOymzAdULnz5FiPgU2pnx2d23lcnzxyBQ/SSXKO3 EUPUWLfJciZcK0tfrEzhCEduruIiMULLYsmwCHxnlKvpLosVkvfeV49mF3O7YZLmjw7whXM nkuXNZP19PjEceeqcapEg== X-UI-Out-Filterresults: notjunk:1;V01:K0:NZNyg+Du8Hg=:RuMAYvGkJ9n6PYqy16HZC+ PsrT+nmlufjIbkx0jUy9SoaZhL/JPHqHPiIaeJAWm7nzxweZYyPBVf8M5kCAW0X5dkbf7ob7j rrug5GyporJsniJeY1DdZtouRcwGO+GuT7s8hcnEjvC6jhm90ertQmeG7t7fzMjg2A5UJ8WHt O48GAqFv3lNnLF91TL4zfIxFKUG2zkX6oKha4Tbh6/GFZLtnKvIskML3OB/uAvWDueJY4flaj N1e9Ia0w9YnA9MsRPmvbvm8xdgso06VsQUWu410HnZghGYItH/6lepw0RCBQr0gsnQ4T9lUcW ZoDepw0hkZz1r4sGzm8I4Av/kUZ7TPsT8MgMvAOXe21uNC/ioreGyi5ztx95pJrOelz7TdJDu Dhyx6CN3o1b9t+ArYDAHhFRiWQHLen0A5K2yk4nKvwFZ8sOppI1fEMVGOSIRgkIet+WMeinYw Ho9ZMMp2kECILjQyxAtjOIe6dHHJJLzt/D4BA0FFEhrI+tOFphE9GeDc4vAsbrKLqYYDCy+OV G+tRVmeJDxrBIalA1iCxTmfSdtrCp3VhEhC01X9Biq8BeEJmQ/lw8Br7EvrzGFDgFPRIKmYTb 9y1nQhQ/XGBIASbJne4qmFagJ8pk4+jK/94zQVu8PZp7DBkexEOZGh1rdh+FEOwFnRwUMCluU JqVN6bKJjzOBMPzW3vbFPa+bD5b3J7tof4yGQe/XpGfpC4Pq0PMB+V+Pm/pe/p8iSUb4/i6nZ sJZ/4I8iuvUr9EgJo2O5d9uA9ycB+72GV4yDTqDpaQblKjtsepxjFRPzj5KqRpdh+chKDZZx/ Al4WZLy2Y5yHRiP3dEg69zXhURA6tSWZzutn7MhlPWYVHzEeXI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 7 Dec 2017 21:55:09 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/sccnxp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c index d6ae3086c2a2..ba1653ba5f37 100644 --- a/drivers/tty/serial/sccnxp.c +++ b/drivers/tty/serial/sccnxp.c @@ -857,10 +857,9 @@ static int sccnxp_probe(struct platform_device *pdev) return PTR_ERR(membase); s = devm_kzalloc(&pdev->dev, sizeof(struct sccnxp_port), GFP_KERNEL); - if (!s) { - dev_err(&pdev->dev, "Error allocating port structure\n"); + if (!s) return -ENOMEM; - } + platform_set_drvdata(pdev, s); spin_lock_init(&s->lock); -- 2.15.1