mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <Avri.Altman@wdc.com>, Bean Huo <huobean@gmail.com>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path
Date: Thu, 28 May 2020 09:18:29 -0700	[thread overview]
Message-ID: <0cc529a9-10a5-2ccd-055e-b9b2a47e5183@acm.org> (raw)
In-Reply-To: <SN6PR04MB4640F8F4B293E6D3980952D5FC8E0@SN6PR04MB4640.namprd04.prod.outlook.com>

On 2020-05-28 07:58, Avri Altman wrote:
>> From: Bean Huo <beanhuo@micron.com>
>> +static void ufshcd_update_desc_length(struct ufs_hba *hba,
>> +                                     enum desc_idn desc_id, int desc_len)
> desc_len is at most 255 so maybe u8?

At least on x86 using types like 'u8' for function arguments may lead to
suboptimal code because it may cause the compiler to insert a widening
instruction. How about changing 'int desc_len' into 'unsigned desc_len'
instead?

Thanks,

Bart.

  parent reply	other threads:[~2020-05-28 16:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 11:56 [PATCH v2 0/3] scsi: ufs: cleanup ufs initialization Bean Huo
2020-05-28 11:56 ` [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc Bean Huo
2020-05-28 13:41   ` Avri Altman
2020-05-28 13:47     ` Bean Huo
2020-05-28 14:56   ` Bart Van Assche
2020-05-28 15:04     ` Bean Huo
2020-05-28 16:16       ` Bart Van Assche
2020-05-28 11:56 ` [PATCH v2 2/3] scsi: ufs: delete ufshcd_read_desc() Bean Huo
2020-05-28 13:47   ` Avri Altman
2020-05-28 14:59   ` Bart Van Assche
2020-05-29  1:12   ` Stanley Chu
2020-05-28 11:56 ` [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path Bean Huo
2020-05-28 14:58   ` Avri Altman
2020-05-28 16:03     ` Bean Huo
2020-05-28 16:18     ` Bart Van Assche [this message]
2020-05-28 15:04   ` Bart Van Assche
2020-05-29  1:26   ` Stanley Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cc529a9-10a5-2ccd-055e-b9b2a47e5183@acm.org \
    --to=bvanassche@acm.org \
    --cc=Avri.Altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=cang@codeaurora.org \
    --cc=huobean@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®