From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D70FCC433FE for ; Sat, 29 Oct 2022 14:22:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbiJ2OW5 (ORCPT ); Sat, 29 Oct 2022 10:22:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbiJ2OWd (ORCPT ); Sat, 29 Oct 2022 10:22:33 -0400 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 724F74BD1D for ; Sat, 29 Oct 2022 07:20:08 -0700 (PDT) Received: from [192.168.1.101] (95.49.29.156.neoplus.adsl.tpnet.pl [95.49.29.156]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 784D93EBD1; Sat, 29 Oct 2022 16:20:06 +0200 (CEST) Message-ID: <0cc72f64-808d-c277-946f-40faf2ea84fc@somainline.org> Date: Sat, 29 Oct 2022 16:20:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 09/12] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} VADC channels Content-Language: en-US To: Manivannan Sadhasivam , andersson@kernel.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org, quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org References: <20221029051449.30678-1-manivannan.sadhasivam@linaro.org> <20221029051449.30678-10-manivannan.sadhasivam@linaro.org> From: Konrad Dybcio In-Reply-To: <20221029051449.30678-10-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.10.2022 07:14, Manivannan Sadhasivam wrote: > Add VADC channels of PM8280_{1/2} PMICs for measuring the on-chip die > temperature and external thermistors connected to the AMUX pins. > > The measurements are collected by the primary PMIC PMK8280 from the > secondary PMICs PM8280_{1/2} and exposed over the PMK8280's VADC channels. > > Signed-off-by: Manivannan Sadhasivam > --- > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index 18315743313b..250e1489f029 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -7,6 +7,7 @@ > /dts-v1/; > > #include > +#include > #include > #include > > @@ -189,6 +190,66 @@ xo-therm@44 { > qcom,ratiometric; > qcom,hw-settle-time = <200>; > }; > + > + pmic-die-temp@103 { > + reg = ; > + label = "pm8280_1_die_temp"; > + qcom,pre-scaling = <1 1>; > + }; > + > + sys-therm@144 { > + reg = ; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; As I mentioned in the previous patch, maybe swapping the order of these two properties would make it look better, but of course that doesn't affect functionality. Reviewed-by: Konrad Dybcio Konrad > + }; > + > + sys-therm@145 { > + reg = ; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; > + }; > + > + sys-therm@146 { > + reg = ; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; > + }; > + > + sys-therm@147 { > + reg = ; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; > + }; > + > + pmic-die-temp@303 { > + reg = ; > + label = "pm8250_2_die_temp"; > + qcom,pre-scaling = <1 1>; > + }; > + > + sys-therm@344 { > + reg = ; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; > + }; > + > + sys-therm@345 { > + reg = ; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; > + }; > + > + sys-therm@346 { > + reg = ; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; > + }; > + > + sys-therm@347 { > + reg = ; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; > + }; > }; > > &qup0 {