From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08EEC38AC8E for ; Fri, 24 Apr 2026 09:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777023028; cv=none; b=mrAL7iTnJuFjhspNTXEi8+p7U9Abyi428alkMvvB7x1mq2QXKhbZ5ZhyDPj33m//NOp8tCKbLwB2Vt4gmdOpWT7JbBWyH1sm81NqjPp7tY32RtMcPrKkRS96t4d4bdvdqpe5/O7A9vNaPApd3yH3vYOZ13KcvxbrfSTija//QEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777023028; c=relaxed/simple; bh=K1xbfy8qRtLcmkS4QP5zxOYSpqrXD25Ls8C/VsoG9gQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=KklYb7o3F6+TayGlaFUyvigrKRGIwpbpn5z+23MPaON8XF6RWrrziSyZMd7lk9y7TG6+r9/UFibZRzNJ+6GUih+N4FukHOd64671TgK6MZqf3ydY5D1d3ns+adhZT2w42QklUihYBKgtZoLIlif9CPPVgyNKCBaXSLDESGtL0/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CMehBFK+; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CMehBFK+" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4890098abbaso57167925e9.0 for ; Fri, 24 Apr 2026 02:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777023025; x=1777627825; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=lWHt/moMI+9wgpJfyIFBg8YgKa+M5uQgee/sMh+PXg0=; b=CMehBFK+8CcDLzn1qU8Do4lbQg4iW0N2FXuhke3rhicC5TD5h5gvqZfLCzTU/+jI/W sxjuYEzL588IWTFAukiBphMw4Zw2BTRk2hQhGDqcGmkB98JekFOcEvPN9AmjVk1Px+I5 ohfDiR7/Qj/GvrPJf9I2JmMAp21JUXyMNGFla4yJ2C91XPFisgTPrhPNt2M8oquHb+5G jk2NSN+ZdR8B8FmVvk8LbXZsMKx7LoLTa3+dXZrCs3HY9gCaq9jXm0fb5YYXGwsZ1aAE DogqTNmjtQdSfxb8bYwtFbCvut3cUwvnftYdPk52Kq1wXH2GwR+ZxXeL5IXgHhuh0nKf gDSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777023025; x=1777627825; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lWHt/moMI+9wgpJfyIFBg8YgKa+M5uQgee/sMh+PXg0=; b=aF+2tzBGgg6308rpy75uyXIz5I/IQ/+TrX6eZZ5Jmrk06mYth9Q8udtIqG6J6FM2k8 qX3UDp8E+jUyrhcvCXaD2R95GONU95UuL+pHIQ/D0Z1vYXVlmx5GCXJ9etvHptRwbqBZ sHFHUC0AUcE+mcGKLVWoDh/b86x1L90poGANyv/y1q3nI8jGag6zFasHZChq+EIKWbWJ WDVPhMJEK0cF0r8p2pG7AQhDiqW6HXuK9wh7TDrXKk9+J+ZdoOnEnrRv3xtm2bI35N8A k2p5HruZt6jcMrgtSuRH02TgBseeJ9oqLOaK0hvqmQh9av1mshzN+Kre46SvlnMgN95c N13Q== X-Forwarded-Encrypted: i=1; AFNElJ+/7X5EBLFuqXhJmGqz/OwQisjghCRiz1GO7pjzWdYmdWc8i88khsF216gqmlONkkx39UkS7x85pezi33s=@vger.kernel.org X-Gm-Message-State: AOJu0YzKrE6beaHK0XKFt/Sq0r4F5NEZz7z2NATLMFu/ZPHooQ325t/r RBwWyEFkuEXGhB0dqUmV6vz0vdLmoYuYIar8LCtym5AlWrdyYdcTrc39ryg9zhp8k88= X-Gm-Gg: AeBDietB4dPEIyv4hZdWMHv1JxYptNu1PTiXuF4+gUktq8lCioYjZPn7j2gBPEP/994 Ply/XFHOcfuF3KYsRFf8IwFDOLFXnMpF8871TQrJHsdI/z3XokcKSiPeCP+TfGer2mVqhGMkoaO DRaLhBHY1DDg1dlNqLj86/71DbJR4Tw7jjsComOUGUt30q4Jpu2v6gevGbJyPdoueOShHPUT5ze ghxVcWcl6q3uPsoHnrN78X931ZVNeZBjsWn2OKq8YR+TUeLOixbUFoWNQ0ZX6OKEjYTGdCb7SQp EfVuEu82pCRVSYIwgarqeAQ/Qj+ohu1LBONs6ayEV2LPgqbt7JY/CH/Parfd2RPuB0o0zAdH7b8 7p1XetOb9fE4MkRO+uSro0gqqNg/okcjHpIar1by5AJQ0eBbgwYhoGh7c420M7k0wABzSarktfp 0/VQW0CsYHWcbpT9S3vczUclTTACqt55NE9NbDnQKikscCvt6j7dR2NusScoIkxQqm4ny33WPcQ gZqCG1kWQyqDf77GA== X-Received: by 2002:a05:600c:620c:b0:488:ae6c:42c6 with SMTP id 5b1f17b1804b1-488fb7786c2mr455899345e9.14.1777023025253; Fri, 24 Apr 2026 02:30:25 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:79e1:f56b:445c:ca9c? ([2a01:e0a:106d:1080:79e1:f56b:445c:ca9c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc100162sm598271405e9.5.2026.04.24.02.30.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 02:30:24 -0700 (PDT) Message-ID: <0cc98ad2-bce8-476a-8f27-2c201eed9828@linaro.org> Date: Fri, 24 Apr 2026 11:30:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/panel/boe-tv101wum-nl6: set MIPI_DSI_MODE_LPM after sending panel disable cmds To: Brady Norander , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260421153147.4378-2-brady.norander@mainlining.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260421153147.4378-2-brady.norander@mainlining.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/21/26 17:31, Brady Norander wrote: > A recent change to Mediatek drm driver enabled HS mode support. With that > change, my MT8183-based krane sku176 chromebook display's colors would look darker > and desaturated after turning the display off and back on. Looking at other panel > drivers, it seems common to enable HS mode to send the disable commands and to > disable HS mode afterwards. However, the boe-tv101wum-nl6 driver would never > disable HS mode, leading to this issue. Update the behavior of boe_panel_disable > to match those other panel drivers. As a side note, I did also test removing the > line which enables HS mode during panel_disable. This worked fine for my device, > but just in case that doesn't work for other devices, I chose to keep that and > instead disable HS mode after sending the panel disable commands. > > Signed-off-by: Brady Norander > > diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > index d5fe105bdbdd..f69b5bd776c0 100644 > --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > @@ -1326,6 +1326,8 @@ static int boe_panel_disable(struct drm_panel *panel) > > mipi_dsi_msleep(&ctx, 150); > > + boe->dsi->mode_flags |= MIPI_DSI_MODE_LPM; > + > return ctx.accum_err; > } > Could you add a Fixes tag ? Neil