From: Vidya Sagar <vidyas@nvidia.com>
To: "Kenneth R. Crudup" <kenny@panix.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: <bhelgaas@google.com>, <lorenzo.pieralisi@arm.com>,
<hkallweit1@gmail.com>, <wangxiongfeng2@huawei.com>,
<mika.westerberg@linux.intel.com>, <kai.heng.feng@canonical.com>,
<chris.packham@alliedtelesis.co.nz>, <yangyicong@hisilicon.com>,
<treding@nvidia.com>, <jonathanh@nvidia.com>,
<abhsahu@nvidia.com>, <sagupta@nvidia.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kthota@nvidia.com>, <mmaddireddy@nvidia.com>,
<sagar.tv@gmail.com>
Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume
Date: Wed, 16 Feb 2022 10:10:07 +0530 [thread overview]
Message-ID: <0ccd43af-0293-521b-86d3-ea2ea1c70e5c@nvidia.com> (raw)
In-Reply-To: <3ca14a7-b726-8430-fe61-a3ac183a1088@panix.com>
On 2/15/2022 6:40 PM, Kenneth R. Crudup wrote:
> External email: Use caution opening links or attachments
>
>
>> On Mon, 7 Feb 2022, Bjorn Helgaas wrote:
>
>>> If the problem really was fixed by some change elsewhere, it *should*
>>> still happen on v5.11-rc1. I think we should verify that and try to
>>> figure out what the other change was.
>
>> Yeah, not a bad idea. I'm a little busy now, but I'll cut a kernel at
>> 4257f7e0, remake, and see what happens. Gimme a day or so.
>
> So I did this- checked out a branch hard-reset to commit 4257f7e0, used my
> current _defconfig on it, and built and tested it- NOW it doesn't exhibit the
> NVMe-device-killing behavior I'd seen a year earlier; I'm assuming Dell must
> have fixed something in the BIOS?
>
> Anyway, I'd done an "lspci -vvvnn" before and after hibernation, if you're
> interested, and a diff of same; I'll send those in subsequent E-mails.
Thanks Kenny for the dump.
I see that the ASPM-L1 state of Realtek NIC which was in disabled state
before hibernate got enabled after hibernate. This is weird. This patch
doesn't do anything to LnkCtl register which has control for ASPM L1
state. Could you please check why ASPM L1 got enabled post hibernation?
>
> -Kenny
>
> --
> Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA
>
next prev parent reply other threads:[~2022-02-16 4:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 12:35 Vidya Sagar
2022-02-01 13:54 ` Kenneth R. Crudup
2022-02-01 18:53 ` Kenneth R. Crudup
2022-02-01 19:03 ` Kenneth R. Crudup
2022-02-01 19:05 ` Kenneth R. Crudup
2022-02-01 19:10 ` Kenneth R. Crudup
2022-02-01 19:24 ` Vidya Sagar
2022-02-01 22:25 ` Kenneth R. Crudup
2022-02-02 4:17 ` Vidya Sagar
2022-02-04 1:18 ` Kenneth R. Crudup
2022-02-04 5:37 ` Vidya Sagar
2022-02-04 23:02 ` Bjorn Helgaas
2022-02-04 23:17 ` Kenneth R. Crudup
2022-02-05 16:44 ` Vidya Sagar
2022-02-05 17:30 ` Kenneth R. Crudup
2022-02-05 17:32 ` Kenneth R. Crudup
2022-02-05 17:33 ` Kenneth R. Crudup
2022-02-07 16:33 ` Bjorn Helgaas
2022-02-07 18:20 ` Kenneth R. Crudup
2022-02-15 13:10 ` Kenneth R. Crudup
2022-02-16 4:40 ` Vidya Sagar [this message]
2022-02-16 6:00 ` Kenneth R. Crudup
2022-02-16 13:11 ` Vidya Sagar
2022-04-12 22:50 ` Bjorn Helgaas
2022-04-13 0:19 ` Kai-Heng Feng
2022-04-14 16:41 ` Bjorn Helgaas
2022-04-15 14:26 ` Kai-Heng Feng
2022-04-15 21:25 ` Bjorn Helgaas
2022-04-21 6:16 ` Kai-Heng Feng
2022-04-21 20:36 ` Bjorn Helgaas
2022-04-21 20:40 ` Kenneth R. Crudup
2022-04-21 21:11 ` Bjorn Helgaas
2022-04-21 21:21 ` Kenneth R. Crudup
2022-04-13 13:26 ` Bjorn Helgaas
2022-11-23 21:44 ` Matthias Kaehlcke
2022-11-23 22:01 ` Kenneth R. Crudup
2022-11-24 0:07 ` Matthias Kaehlcke
2022-02-15 13:12 ` Kenneth R. Crudup
2022-02-04 11:23 ` Abhishek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ccd43af-0293-521b-86d3-ea2ea1c70e5c@nvidia.com \
--to=vidyas@nvidia.com \
--cc=abhsahu@nvidia.com \
--cc=bhelgaas@google.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kai.heng.feng@canonical.com \
--cc=kenny@panix.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mmaddireddy@nvidia.com \
--cc=sagar.tv@gmail.com \
--cc=sagupta@nvidia.com \
--cc=treding@nvidia.com \
--cc=wangxiongfeng2@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®