From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BF8A2E84A for ; Fri, 5 Apr 2024 07:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712301931; cv=none; b=s85z2WyGFbf4G8NDTSNJyiP5pcHEW6gh/jFkmZ2XBOuBPJJg+jbYTUVbyIGn0yLFTFKQNY20P7oT87hmQtRlwEgMl3fpv0xZzwyLMqpB4RUB1dtVIMQ2nubMf0mNCzontUtXQaFgBW36ZapdkWW3W/B03aUViCuOlezK4nelji0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712301931; c=relaxed/simple; bh=CJC4uUI0O0fhPXhX1SBfBbQJeLp8u6GlGINuTVi841I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k3dF4LK2EDzK0HNGnOOBx8N3NUZCgw/7ZS5lm6Xj4NZ/5MndZTIVN16yUnL1mRq6PhAaFHgM8y2siBJBIYr3bvuUpzY25TjLpUegTJWxRZxcVOq6EgyCylG/uDxxwdHPTiA2Z0RHx7diWpckRp/tnwnL+n515S9N808yAxlAciU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bzQigq2V; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bzQigq2V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712301928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lkdM4XQ6M6HZSTepNlp3Gm4K0YAV75X1B0OZtU24JGA=; b=bzQigq2V8OZej1ysCgtphMYVdlW6Z9EKsSmvKMxyhJywI7ba/JZh2vKqOyRKf5jv/kv0yJ XxMHGLFBms7XY3Han5D2cceTdE0HynS84MFI6TCJRIc8j5p6CDn1SvJ+ahmX8BnVJNlwMf of/AnkLnwSwWijLJRuKlQRbRPPmXBac= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-167-oF87AeoqPbqiOQs7Fhy0Yg-1; Fri, 05 Apr 2024 03:25:24 -0400 X-MC-Unique: oF87AeoqPbqiOQs7Fhy0Yg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-343e775c794so194575f8f.0 for ; Fri, 05 Apr 2024 00:25:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712301923; x=1712906723; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lkdM4XQ6M6HZSTepNlp3Gm4K0YAV75X1B0OZtU24JGA=; b=dYCQMIUlIKR/++sXGvAa4tNUyF/AIXeBn71QlgkGHo5r8wUJR8hz2uE100q3HmjEEm deC/LaNYpgO6hep1uOFzThU6ELe8FffGwnJeMyszhUXc3gq/IK/74qha7bIS0cmTVVb9 fNXEQFqb6oeI+VE8KoYlpUGG3Mpb1ZbaFYBi4cPVNJSIrUylw/xu7IRxAwafTrXtQlSa tK+DsOyWseC4y9qbYTHTqOjnNaJFoLnNONejSM/VgCFIgniNJp8sEKEJ2uFPR61KwWJr 0HvD7etYaHfyG+xx4eJ1k45cPqiNXzqz8cw+YFwwu1T6ZFmispAZK/ZOsAZAaw1WSw9G S6aA== X-Forwarded-Encrypted: i=1; AJvYcCUBP3sAxWmd+aSWNEWeicoF6la2Tdzqf2X/x6q/dX9oSyXmKljneCeuly4K+ctxpC3cdpTITqA9wxmn+DTAoXmS327/neooGNOW1Ncr X-Gm-Message-State: AOJu0Yyll4gMIed8aCREir5Eo6o1DE+s2Hseq/ENi+gXlXIOAL4suH1m 2xXWmGBIN/z9bnrg7QIUmBMhv+r0p6MLUJrPWbP/YMPbQZy2PjmHDKKxiDEmQSaynF1lnX9+mel 4s6gfHpZSP0MeoKHz7KlbV0rnD795zea6diJoOUpe7KB9fihoha+RToGcVpu+Qg== X-Received: by 2002:a5d:5687:0:b0:341:ce05:dba5 with SMTP id f7-20020a5d5687000000b00341ce05dba5mr500772wrv.30.1712301923782; Fri, 05 Apr 2024 00:25:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGK8jClUPaXF5KqvriKEiry8p3SLvc62Uf388WNTpbggEOg0dhpzskzC2J4/2x2bnFd87Zgdw== X-Received: by 2002:a5d:5687:0:b0:341:ce05:dba5 with SMTP id f7-20020a5d5687000000b00341ce05dba5mr500757wrv.30.1712301923392; Fri, 05 Apr 2024 00:25:23 -0700 (PDT) Received: from [192.168.3.108] (p4ff2306b.dip0.t-ipconnect.de. [79.242.48.107]) by smtp.gmail.com with ESMTPSA id u10-20020adff88a000000b00343e01d3f6dsm1187049wrp.3.2024.04.05.00.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 00:25:22 -0700 (PDT) Message-ID: <0ccd43e9-fde3-4e13-8140-7d344b420e23@redhat.com> Date: Fri, 5 Apr 2024 09:25:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/14] mm/ksm: add folio_set_stable_node To: alexs@kernel.org, Matthew Wilcox , Andrea Arcangeli , Izik Eidus , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryncsn@gmail.com Cc: Hugh Dickins , Chris Wright References: <20240325124904.398913-1-alexs@kernel.org> <20240325124904.398913-4-alexs@kernel.org> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240325124904.398913-4-alexs@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.03.24 13:48, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > Turn set_page_stable_node() into a wrapper folio_set_stable_node, and then > use it to replace the former. we will merge them together after all > place converted to folio. > > Signed-off-by: Alex Shi (tencent) > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > --- > mm/ksm.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index ea3dabf71e47..c9b7c5701f22 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1109,6 +1109,12 @@ static inline void set_page_stable_node(struct page *page, > page->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM); > } > > +static inline void folio_set_stable_node(struct folio *folio, > + struct ksm_stable_node *stable_node) > +{ > + set_page_stable_node(&folio->page, stable_node); > +} > + > #ifdef CONFIG_SYSFS > /* > * Only called through the sysfs control interface: > @@ -3241,7 +3247,7 @@ void folio_migrate_ksm(struct folio *newfolio, struct folio *folio) > * has gone stale (or that folio_test_swapcache has been cleared). > */ > smp_wmb(); > - set_page_stable_node(&folio->page, NULL); > + folio_set_stable_node(folio, NULL); > } > } > #endif /* CONFIG_MIGRATION */ Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb