From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 985923A7F5B for ; Wed, 7 Jan 2026 17:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767808504; cv=none; b=EBVejeQQ6E70Lf6OmB21rpBRG0pjf2z/idtjeUTaM8e/oJihj6E3EY/xuO6P9R4st72DZM8MsBIpeb+3WQo1JuunaOymFACR6ETW+IIs3VKtWqWEQjlKjLAmpj86E2zFOtx0cRoe2VAdr5pl/niywliThs7eRMhZrgKvlP/bT3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767808504; c=relaxed/simple; bh=FskVu4bMK9X3YY1c0FaKoNF9nvaMiNegDxZbSfSbmrA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EXMnkwxGOwRvmlbyeqGeim0NZMhou2Emtt6UcKNKDOB5RrqY8ehNY/s7LAbk3xjIPJ4Wg13Xi1yPo3z3oG5k0ons65u4/cqueOXwrDZFIamt9UFAcHEBL7lIZe3G6hpmy0iSUhl0xjuTE4AyOsv6cdbJNsKasBivk6v0QZYlklo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jnhuDG/3; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jnhuDG/3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1767808498; bh=FskVu4bMK9X3YY1c0FaKoNF9nvaMiNegDxZbSfSbmrA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jnhuDG/3RzbHLW1cDYXDpDfODx6dx6Z0mYekdHtI7n6ljoYmOpR8UdCzieAdPOkqV tWZDw6yi12pV926Ako6rRlA2ep5ppnD6bKo99VWcrCjnGJzLlluGHtGGfu6puAuSrN FuPx33eXiiGxXNUiFRKJMVSbgJeTeEh0eDXgWlXK1jIGLP8IFJ7JL5VCT3YitdAXkJ j6LXSlvEblONUjRt6BQIOs/1qxupairXBfjIWNgpuuh9+pasqr5JkFkg7H/HILq+Be JJN0+7rpNy5fmD1jghz1i8dnQrE/fL7tShPWd+RO3kf0wcoVkWRjU9XFMS1v7wo17H R4FYG+jdDqdvA== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7F0CC17E13F6; Wed, 7 Jan 2026 18:54:57 +0100 (CET) Message-ID: <0cce5e09-1947-46b4-8ffc-1aa880accc9a@collabora.com> Date: Wed, 7 Jan 2026 19:54:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] Introduce BACKGROUND_COLOR DRM CRTC property To: Diederik de Haas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Matt Roper References: <20251118-rk3588-bgcolor-v3-0-a2cc909428ea@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Diederik, On 1/7/26 2:18 PM, Diederik de Haas wrote: > Hi, > > On Tue Nov 18, 2025 at 12:51 AM CET, Cristian Ciocaltea wrote: >> Some display controllers can be hardware-configured to present non-black >> colors for pixels which are not covered by any plane (or are exposed >> through transparent regions of higher planes). >> ... >> The subsequent patches add background color support to VKMS and the VOP2 >> display controller used in the RK3568, RK3576, and RK3588 Rockchip SoC >> families. > > Cristian provided a helper script which would show a test pattern and > then iterate through setting Red, Green, Blue background color and then > set it back to the original value. > > I first tested this on a Rock 5B (RK3588). > Without this patch set, the background color was Black with every > iteration. But with this patch set, I did see a Red, Green and Blue > background color, after which it was set back to Black. > > diederik@rock5b:~$ grep -E "^Changing prop|^Read BACKGROUND_COLOR" bgcol-test-bash-user.log > Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 > Changing prop value to: 0xffff00000000ffff > Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff > Changing prop value to 0xffffffff00000000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffffffff00000000 > Changing prop value to 0xffff0000ffff0000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffff0000ffff0000 > Changing prop value to 0xffff00000000ffff > Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff > Changing prop value to: 0xffff000000000000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 > > I then did the same test on a Quartz64-B (RK3566) and that too showed a > Red, Green and Blue background color and then was set back to Black. > > diederik@quartz64b:~$ grep -E "^Changing prop|^Read BACKGROUND_COLOR" bgcol-test-bash-user-q64b.log > Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 > Changing prop value to: 0xffff00000000ffff > Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff > Changing prop value to 0xffffffff00000000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffffffff00000000 > Changing prop value to 0xffff0000ffff0000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffff0000ffff0000 > Changing prop value to 0xffff00000000ffff > Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff > Changing prop value to: 0xffff000000000000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 > > So this patch set does what it is supposed to do, so feel free to add: > > Tested-by: Diederik de Haas Thanks for taking the time to test this! Please note there's a newer revision of the series: https://lore.kernel.org/all/20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com/ Regards, Cristian