From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14AE9C4363A for ; Tue, 20 Oct 2020 18:54:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBF342222D for ; Tue, 20 Oct 2020 18:54:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437780AbgJTSy3 (ORCPT ); Tue, 20 Oct 2020 14:54:29 -0400 Received: from smtprelay0058.hostedemail.com ([216.40.44.58]:58230 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2437740AbgJTSy3 (ORCPT ); Tue, 20 Oct 2020 14:54:29 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 6D6A21802150E; Tue, 20 Oct 2020 18:54:28 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: shoe55_10129fa27242 X-Filterd-Recvd-Size: 2143 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 20 Oct 2020 18:54:26 +0000 (UTC) Message-ID: <0cdbe9c56d73402be9e3b36a662c68515abcfae9.camel@perches.com> Subject: Re: [RFC] treewide: cleanup unreachable breaks From: Joe Perches To: Nick Desaulniers Cc: Tom Rix , LKML , clang-built-linux , Greg KH , George Burgess , Arnd Bergmann , Jason Gunthorpe Date: Tue, 20 Oct 2020 11:54:25 -0700 In-Reply-To: References: <20201017160928.12698-1-trix@redhat.com> <20201018054332.GB593954@kroah.com> <3bc5c2e3b3edc22a4d167ec807ecdaaf8dcda76d.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-10-20 at 11:51 -0700, Nick Desaulniers wrote: > On Tue, Oct 20, 2020 at 11:42 AM Joe Perches wrote: > > On Mon, 2020-10-19 at 12:42 -0700, Nick Desaulniers wrote: > > > We probably should add all 3 to W=2 builds (wrapped in cc-option). > > > I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to > > > follow up on. > > > > I suggest using W=1 as people that are doing cleanups > > generally use that and not W=123 or any other style. > > > > Every other use of W= is still quite noisy and these > > code warnings are relatively trivially to fix up. > > The 0day bot folks have enabled W=1 recently; hence the uptick in > reports of -Wimplicit-function-declaration. > > If it gets added to W=1, it's effectively "on by default" for new code > tested by 0day bot. And that would mean these get fixed faster no? Isn't that a good thing?