From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AE581D095C for ; Sat, 26 Oct 2024 10:32:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729938761; cv=none; b=WXeBRCrBxq7jhMz0QY9MPwjn82p7Fh8MD6eJ/pntCqDHAZ+33TA9GnPzJO8Id2go6dVARKrukgyJtc38Y+CKU3A6e3R947x1FSM+p9L26Q4e/VJmKh7VsMBHSO+YxlB+JRgKoBfdj4sOCq6f9g4D5tJlVvRWYkKGiZ0nofUD6zE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729938761; c=relaxed/simple; bh=SwQIYXHahAYM/4giphhwTe9mjAhQAeeDSM7ktjnLMhc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QINTvFpYLHx3MrzSSJ4P7IJ352F2rYY41ZqHwPY12SvdaSVVRXsxio07YK3f7A0D7+Y0gdScuowmfpD+sXLDl5eqNWlhg9gTdr1qf81odFtQvVofWCG2vlOOh7syBNy7PWbv5uI15b3Zd1bwtDvrE1LQIHUTa4LZtnfQmjwXZuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OsPppbJX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OsPppbJX" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49Q602d2022574 for ; Sat, 26 Oct 2024 10:32:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sDJqoZnQ7dr7g8Y5z3Fc/PH3Ed2vC8x8CbYp4pSGv7Y=; b=OsPppbJXtRYmK9cy wh6lt6L399DXFLLxZevz55u1K2jCTCOx7VZwgwcX66P2hvNVavcX6QXFCvHOznJS dUbdaydLv7mEEVK1Q9l0avAaCHsPgHdDjQAfBRKY9XGKJO7Y4Xr1etxZKK+K1gHl dL58H5nOEQXvyWYJJvMQktM2+xarxarWh0cwy017LA9YsM4iIaVmjwWU9y+MYMis nca9c7OKTIMmbGTivAw8bflsIhl8ljDiBT1n6P6gpX9Ry1TXLn0xpOs0JnwQ4AJF u92qg7B4+8k4dUYwppFFU4m6KfpUu1Ga14MKaNXB0zOlH332PiTDvlYwTSJyjtb/ G7ZG3w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42gskjrnen-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 26 Oct 2024 10:32:37 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6cbe5e8658fso5898886d6.0 for ; Sat, 26 Oct 2024 03:32:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729938756; x=1730543556; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sDJqoZnQ7dr7g8Y5z3Fc/PH3Ed2vC8x8CbYp4pSGv7Y=; b=AnEBn3QDZZtlS/YqLWtM3Qa+XT50lbSnUAGXalefoX08sZ1/rV87IvmnpE//Mr2AtD Od6Hp2H9a7yTuqf1JtXlezpycILHoZV6j6Kk+MMRR7ICXvIaUDJ8sX5Cblq4vzz6LvZf iMNjAYQZR7L/jEsDrKrDIE8dLZg5IakWxlSzMO+CfOWANacksLTWBa2Ff0SawGME6RfK MqknS+OkqgU7ZUQAIe4XFWhdaTaNGKevs0Kx1nM6VaNFbGMARKtoer34Ar2YkG5P88HF fvM04ul2ncAsfdlPgqDCqRysbT4NaFZJpYVD8pE2N7cEbYwK8m5TB7mUHS2Yc5i274jZ qk4g== X-Forwarded-Encrypted: i=1; AJvYcCUpWuszAzcFTIC3j+M/5dmLoiEFqWM00n33nt2JDdH59jNhBdig80sax30HyAnOD/sg4La1ASoxd7ilML4=@vger.kernel.org X-Gm-Message-State: AOJu0YyYMduiH+iwK48YPmwuzkUgD/vcp9PJkyH4NgMtw4Unl96C8ndt 7++ALiuGNl9fDBEZgGrDoebEokGRuXFEffkf4Lu7BhuQNugFSlmn5hQcRnEvuAR3jSBe3puxmMl rUCAXt5954US3bMScpD5uhhOplVbP3q4hyqTXCBL2NQSsBUN6ZXKJ1ZrFVB0+dOo= X-Received: by 2002:a05:6214:1c43:b0:6cb:e6ed:eec8 with SMTP id 6a1803df08f44-6d185861dc6mr16682406d6.10.1729938755961; Sat, 26 Oct 2024 03:32:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjXZJAA3eb2Zr0VM+fkgskt/jYIPag26aqMf/uO5v7pcDYcm3MAe2D79PI+mBVRZS9oQTAaA== X-Received: by 2002:a05:6214:1c43:b0:6cb:e6ed:eec8 with SMTP id 6a1803df08f44-6d185861dc6mr16682346d6.10.1729938755683; Sat, 26 Oct 2024 03:32:35 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1dec8169sm161200666b.34.2024.10.26.03.32.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Oct 2024 03:32:35 -0700 (PDT) Message-ID: <0cdd22af-150a-4dbc-8436-13211d93d417@oss.qualcomm.com> Date: Sat, 26 Oct 2024 12:32:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 10/12] arm64: dts: qcom: sdm845-starqltechn: add initial sound support To: Dzmitry Sankouski , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241008-starqltechn_integration_upstream-v6-0-5445365d3052@gmail.com> <20241008-starqltechn_integration_upstream-v6-10-5445365d3052@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241008-starqltechn_integration_upstream-v6-10-5445365d3052@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ot8P-9m_Tgo6_GmTRDBWelmtwJb-aZ5N X-Proofpoint-ORIG-GUID: ot8P-9m_Tgo6_GmTRDBWelmtwJb-aZ5N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410260088 On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote: > Add support for sound (headphones and mics only) > Also redefine slpi reserved memory, because adsp_mem overlaps with > slpi_mem inherited from sdm845.dtsi. > > Signed-off-by: Dzmitry Sankouski > > --- [...] > +&sound { > + compatible = "qcom,sdm845-sndcard"; > + model = "Samsung Galaxy S9"; Are spaces cool with userspace? > + pinctrl-0 = <&quat_mi2s_active &quat_mi2s_sd0_active &quat_mi2s_sd1_active>; > + pinctrl-names = "default"; > + status = "okay"; > + > + audio-routing = "RX_BIAS", "MCLK", > + "AMIC2", "MIC BIAS2", /* Headset Mic */ > + "AMIC3", "MIC BIAS2", /* FMLeft Tx */ > + "AMIC4", "MIC BIAS2", /* FMRight Tx */ > + "DMIC0", "MIC BIAS1", /* Digital Mic0 */ > + "DMIC5", "MIC BIAS4", /* Digital Mic1 */ > + "DMIC4", "MIC BIAS4", /* Digital Mic2 */ > + "DMIC3", "MIC BIAS3", /* Digital Mic3 */ > + "DMIC2", "MIC BIAS3", /* Digital Mic4 */ > + "DMIC1", "MIC BIAS1"; /* Digital Mic5 */ > + > + mm1-dai-link { > + link-name = "MultiMedia1"; > + cpu { Please add a newline before subnodes [...] > + > + codec { > + sound-dai = <&wcd9340 2>; /* AIF2_PB */ It would be nice to create a binding for wcd9340, like include/dt-bindings/sound/qcom,wcd9335.h Konrad