mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/prom: fix early DEBUG messages
Date: Fri, 14 Dec 2018 11:37:58 +0100	[thread overview]
Message-ID: <0cde4fdd-9d16-732f-ebf8-b06127929e63@c-s.fr> (raw)
In-Reply-To: <87pnu4vd94.fsf@concordia.ellerman.id.au>



Le 14/12/2018 à 07:22, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
> 
>> diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
>> index fe758cedb93f..d8e56e03c9c6 100644
>> --- a/arch/powerpc/kernel/prom.c
>> +++ b/arch/powerpc/kernel/prom.c
>> @@ -749,7 +749,11 @@ void __init early_init_devtree(void *params)
>>   	memblock_allow_resize();
>>   	memblock_dump_all();
>>   
>> +#ifdef CONFIG_PHYS_64BIT
>>   	DBG("Phys. mem: %llx\n", memblock_phys_mem_size());
>> +#else
>> +	DBG("Phys. mem: %x\n", memblock_phys_mem_size());
>> +#endif
> 
> Can we just do:
> 
>    	DBG("Phys. mem: %llx\n", (unsigned long long)memblock_phys_mem_size());
> 
> ?
> 

Yes that's obviously better, especially as we don't fix the length of 
the displayed value.
Christophe

      reply	other threads:[~2018-12-14 10:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 13:54 Christophe Leroy
2018-12-14  6:22 ` Michael Ellerman
2018-12-14 10:37   ` Christophe Leroy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cde4fdd-9d16-732f-ebf8-b06127929e63@c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®