From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Cc: Johan Hovold <johan@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding
Date: Wed, 12 Jul 2023 13:48:19 +0200 [thread overview]
Message-ID: <0ce7d468-c0f5-e29f-d4cc-3bdcfcc2bff4@linaro.org> (raw)
In-Reply-To: <20230712113731.3306-3-wsa+renesas@sang-engineering.com>
On 12/07/2023 13:37, Wolfram Sang wrote:
> Needed to enable this chip on a Renesas KingFisher board. Description
> copied over from the Mediatek driver which already supports it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> index 4835a280b3bf..8f6992b97ca6 100644
> --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> @@ -41,6 +41,12 @@ properties:
> description: >
> Backup voltage regulator
>
> + reset-gpios:
> + maxItems: 1
> + description: >
> + An optional reset line, with names such as RESET or NRESET.
> + If the line is active low it should be flagged with GPIO_ACTIVE_LOW.
> +
> required:
> - compatible
> - vcc-supply
> @@ -54,5 +60,6 @@ examples:
> compatible = "u-blox,neo-8";
> v-bckp-supply = <&gnss_v_bckp_reg>;
> vcc-supply = <&gnss_vcc_reg>;
> + reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
This should complain with errors, because of missing header for the
defines, so usual disclaimer:
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-12 11:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 11:37 [PATCH 0/3] gnss: ubx: updates to support the Renesas KingFisher board Wolfram Sang
2023-07-12 11:37 ` [PATCH 1/3] gnss: ubx: use new helper to remove open coded regulator handling Wolfram Sang
2023-07-12 11:50 ` Geert Uytterhoeven
2023-07-12 11:37 ` [PATCH 2/3] dt-bindings: gnss: u-blox: add "reset-gpios" binding Wolfram Sang
2023-07-12 11:48 ` Krzysztof Kozlowski [this message]
2023-07-12 11:52 ` Geert Uytterhoeven
2023-07-12 12:16 ` Rob Herring
2023-07-12 11:37 ` [PATCH 3/3] gnss: ubx: add support for the reset gpio Wolfram Sang
2023-07-12 11:58 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ce7d468-c0f5-e29f-d4cc-3bdcfcc2bff4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®