From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Yaxiong Tian <iambestgod@qq.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yaxiong Tian <tianyaxiong@kylinos.cn>
Subject: Re: [PATCH v2 1/3] nvme: Add warning for PST table memory allocation failure in nvme_configure_apst
Date: Tue, 1 Apr 2025 02:49:38 +0000 [thread overview]
Message-ID: <0cfd6ac7-7063-4739-a3a2-8c080c3ab02e@nvidia.com> (raw)
In-Reply-To: <tencent_10073A637F934BE4C78884A0465872286C09@qq.com>
On 3/27/25 18:40, Yaxiong Tian wrote:
> From: Yaxiong Tian<tianyaxiong@kylinos.cn>
>
> Currently the function fails silently on PST table memory allocation failure.
> Add warning messages to improve error visibility.
>
> Signed-off-by: Yaxiong Tian<tianyaxiong@kylinos.cn>
seems useful while debugging, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-04-01 2:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 1:38 [PATCH v2 0/3] nvme: Add sysfs interface for APST configuration management Yaxiong Tian
2025-03-28 1:40 ` [PATCH v2 1/3] nvme: Add warning for PST table memory allocation failure in nvme_configure_apst Yaxiong Tian
2025-04-01 2:49 ` Chaitanya Kulkarni [this message]
2025-03-28 1:40 ` [PATCH v2 2/3] nvme: add sysfs interface for APST table updates Yaxiong Tian
2025-04-01 2:55 ` Chaitanya Kulkarni
2025-04-01 8:56 ` Yaxiong Tian
2025-03-28 1:40 ` [PATCH v2 3/3] nvme: add per-controller sysfs interface for APST configuration Yaxiong Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cfd6ac7-7063-4739-a3a2-8c080c3ab02e@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=iambestgod@qq.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tianyaxiong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®