From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754057AbdFPOIq (ORCPT ); Fri, 16 Jun 2017 10:08:46 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:28043 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753101AbdFPOIc (ORCPT ); Fri, 16 Jun 2017 10:08:32 -0400 X-AuditID: b6c32a39-f790c6d000000e85-bf-5943e65c9b61 Subject: Re: [RFT 2/2] pinctrl: samsung: Fix invalid register offset used for Exynos5433 external interrupts To: Krzysztof Kozlowski Cc: Tomasz Figa , Linus Walleij , Kukjin Kim , Marek Szyprowski , Chanwoo Choi , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Donglin Peng , stable@vger.kernel.org From: Sylwester Nawrocki Message-id: <0cfe358a-c050-aae0-5755-819c7b25ef28@samsung.com> Date: Fri, 16 Jun 2017 16:08:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-version: 1.0 In-reply-to: <20170614131828.28683-2-krzk@kernel.org> Content-type: text/plain; charset="utf-8"; format="flowed" Content-language: en-GB Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTYRjG+3Z2zo7Txde8vdiVdQGFTCnhVCalRkP6IyRkRhdXntS8sqmp IBmi5iVnJaHT0NQwb2ibmEpX71ao4a3QqWVqZa2mhmHLcjsK/vd73+d7vofn46MJcTfpQIdE RLOKCHmYhBLyG1odXfaem/byd5nQIWZ4YYZkpqqGSUY1OUswvb11AibXWM5jNJNDJKMtMiKm v7mQYvJ6n/GYmjadgCl+9BExlc1GdNRK2qTWCaSaynRKOjr0hJJqy65Js+srkXRes+0UdUbo HsiGhcSyin0eAcJgTXUzPypFEJc1mMxLQp/IDGRBAz4ADRWtPI7toG+slspAQlqMGxHos5v4 3DCP4OW/QmrN0fZngccJNQiKuqvMghiPI8iYwya2xhGQY3hFmNgGO8Lw30XSZCCwioD0pw+Q SaCwK9xszzazCHtAUWuX2cDHu6G0/b15b4tlUHL7loA7swl+3xnjm9gCu8FPQ4s5mMCHYHo5 heTYHjrGOS+Bt4O2+jthCgbcI4DZssWVi+iVYStoXhBcG2+oK8hZ7W8NXzvrBRw7wPUvH3ic V4WgqzoZcUMegtG0NcdhaO18u5q8EfS/skguQAQ3UsXcESkMqQwUtz4GmW/Ocy+nRfDweSaZ g3ao13VTr+ujXtdHva5PMeJXIjs2ShkexCpdo9yclfJwZUxEkPOlyHANMn8wp4ONqKPnZAvC NJJYiWQ6L38xKY9Vxoe3IKAJiY2oa3hlJQqUxyewisgLipgwVtmCNtN8ib3ItnZIJsZB8mg2 lGWjWMWayqMtHJJQemKCY5P03Yii3zd/lthRbSx101Q4DWTtL3s85rfzrow1jEWnViWW+Oa6 6+t8sidVNj6FtX73dD8unz67lId4DZ5X82WNc8UJnoN5RzSvyz9PjaQtzeyKO27cciV4oPQE HWs5c78gLji207skYMLBJVSv/dZnabi4vGc0RWS3wVXCVwbLXZ0IhVL+HxGzjIlcAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRmVeSWpSXmKPExsVy+t9jQd3oZ86RBuc7jC2uf3nOavF09XVW i/7Hr5ktzp/fwG4x5c9yJotNj6+xWmye/4fR4vKuOWwWM87vY7JYe+Quu8WCjY8YLVbt+sPo wOOxc9Zddo9NqzrZPO5c28PmsXlJvUffllWMHp83yQWwRbnZZKQmpqQWKaTmJeenZOal2yqF hrjpWigp5CXmptoqRej6hgQpKZQl5pQCeUYGaMDBOcA9WEnfLsEtY9OaXSwFrewVPVebmRoY n7B2MXJySAiYSBz5/YUJwhaTuHBvPVsXIxeHkMBqRomri/4xgiSEBB4ySqxYkwhiCwvkSXRu 3csCYosIaEpc//sdbBCzwERmiTVT1SDqNzNK7P/DDGKzCRhK9B7tA5vDK2AnMf/wCbA4i4Cq xOKjN8HiogIREruuH2CFqBGU+DH5Hth8TgFTiQ8fD7FBzDeT+PLyMNQucYlj9yF6mQXkJTav ecs8gVFwFpL2WUhaZiFpmYWkZQEjyypGrtSC4tz03GKjAsNNjMCI3XZYy38H44+z0YcYBTgY lXh4GW47RwqxJpYVV+YeYpTgYFYS4T1xHSjEm5JYWZValB9fVJqTWnyI0RTopYnMUqLJ+cBk klcSb2hiaWRiYGZmaGRgbKYkzjsh8EuEkEB6YklqdmpqQWoRTB8TB6dUA+NEgTDDwJ5eGf8Q IZHqBoGvb3kyIvP6cl6eW/P03BSbO2pim09U7J7q23tu0fv5vY57TXatfKCjWjwt3/jim4XS 1h97+L5t5P04o3d/7O4G64ddFyY/KW1qFN0qLH335TkWo7gExcDF+1evak6cUG/7WfWiZjXT t5vSB657FJ5nub5n+ynvs7uVWIozEg21mIuKEwHBMTaA7gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170616140827epcas1p182c6222e96dcad797afa1212bdf2d7e7 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170614131847epcas3p4755a0ad1e25550134ddfcf0db9aff06b X-RootMTR: 20170614131847epcas3p4755a0ad1e25550134ddfcf0db9aff06b References: <20170614131828.28683-1-krzk@kernel.org> <20170614131828.28683-2-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2017 03:18 PM, Krzysztof Kozlowski wrote: > When setting the pin function for external interrupts, the driver used > wrong IO memory address base. The pin function register is always under > pctl_base, not the eint_base. > > By updating wrong register, the external interrupts for chosen GPIO > would not work at all and some other GPIO might be configured to wrong > value. > > Platforms other than Exynos5433 should not be affected as eint_base > equals pctl_base in such case. > > Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank") > Cc: > Reported-by: Tomasz Figa > Signed-off-by: Krzysztof Kozlowski The patch looks good to me, I'll try to test it later today. Reviewed-by: Sylwester Nawrocki -- Thanks, Sylwester