From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Pin-yen Lin <treapking@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: parade,ps5511: Disallow unevaluated properties
Date: Fri, 16 Jan 2026 08:55:19 +0100 [thread overview]
Message-ID: <0d04b5c6-4e4a-41c0-ba14-09c95a6df235@oss.qualcomm.com> (raw)
In-Reply-To: <20260112202040.GA943734-robh@kernel.org>
On 12/01/2026 21:20, Rob Herring wrote:
> On Mon, Jan 12, 2026 at 10:01:50AM +0100, Krzysztof Kozlowski wrote:
>> Review given to v2 [1] of commit fc259b024cb3 ("dt-bindings: usb: Add
>> binding for PS5511 hub controller") asked to use unevaluatedProperties,
>> but this was ignored by the author probably because current dtschema
>> does not allow to use both additionalProperties and
>> unevaluatedProperties. As an effect, this binding does not end with
>> unevaluatedProperties and allows any properties to be added.
>>
>> Fix this by reverting the approach suggested at v2 review and using
>> simpler definition of "reg" constraints.
>>
>> Link: https://lore.kernel.org/r/20250416180023.GB3327258-robh@kernel.org/ [1]
>> Fixes: fc259b024cb3 ("dt-bindings: usb: Add binding for PS5511 hub controller")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/usb/parade,ps5511.yaml | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/parade,ps5511.yaml b/Documentation/devicetree/bindings/usb/parade,ps5511.yaml
>> index 10d002f09db8..154d779e507a 100644
>> --- a/Documentation/devicetree/bindings/usb/parade,ps5511.yaml
>> +++ b/Documentation/devicetree/bindings/usb/parade,ps5511.yaml
>> @@ -15,6 +15,10 @@ properties:
>> - usb1da0,5511
>> - usb1da0,55a1
>>
>> + reg:
>> + minimum: 1
>> + maximum: 5
>> +
>
> This 'reg' would be the upstream USB port. We have no idea what its
> constraints are for the value.
Indeed.
>
>> reset-gpios:
>> items:
>> - description: GPIO specifier for RESETB pin.
>> @@ -41,12 +45,6 @@ properties:
>> minimum: 1
>> maximum: 5
>>
>> -additionalProperties:
>> - properties:
>> - reg:
>> - minimum: 1
>> - maximum: 5
>
> Removing this is wrong. This is defining the number of downstream USB
> ports for this hub.
>
> What's wrong here is 'type: object' is missing, so any property that's
> not a object passes (no, 'properties' doesn't imply it's an object).
>
> We should fix dtschema to allow additionalProperties when not a
> boolean property to coexist with unevaluatedProperties. I'll look into
> it.
I see your commit. I will send v2 of this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-16 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 9:01 Krzysztof Kozlowski
2026-01-12 9:01 ` [PATCH 2/2] dt-bindings: usb: realtek,rts5411: " Krzysztof Kozlowski
2026-01-12 20:20 ` [PATCH 1/2] dt-bindings: usb: parade,ps5511: " Rob Herring
2026-01-12 23:17 ` Rob Herring
2026-01-16 7:55 ` Krzysztof Kozlowski [this message]
2026-01-16 7:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d04b5c6-4e4a-41c0-ba14-09c95a6df235@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=treapking@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®