From: John Garry <john.garry@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"irogers@google.com" <irogers@google.com>,
"kjain@linux.ibm.com" <kjain@linux.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>
Subject: Re: [PATCH] perf metricgroup: Fix system PMU metrics
Date: Wed, 20 Jan 2021 13:07:57 +0000 [thread overview]
Message-ID: <0d064a9b-bbb6-4ef9-b959-d64c14850319@huawei.com> (raw)
In-Reply-To: <20210120125622.GE1760208@krava>
On 20/01/2021 12:56, Jiri Olsa wrote:
> that's fixing the issue for me, this was crashing:
> # perf stat -a -I 1000 -M L1D_Cache_Fill_BW,L2_Cache_Fill_BW
>
> could you please send it formaly, so it can be merged?
>
I will do it today. But I want to make sure that the logic is correct,
so checking it all again, i.e. I can fix the segfault but the logic may
be wrong.
I think Ian wrote this code originally or made the most recent rework
(which I tried to fix), so would like him to check also.
> I can't reproduce the original patch issue and I need
> to check the code in more depth
It should only occur for metrics when using system PMUs, i.e. match via
identifier file, so I really doubt your system has them.
I'd like to add a test for this - I need to think how...
Cheers,
John
next prev parent reply other threads:[~2021-01-20 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 10:04 John Garry
2021-01-19 10:56 ` Joakim Zhang
2021-01-19 11:04 ` John Garry
2021-01-19 11:13 ` Joakim Zhang
2021-01-19 12:02 ` John Garry
2021-01-19 15:47 ` John Garry
2021-01-19 17:33 ` John Garry
2021-01-20 5:15 ` Joakim Zhang
2021-01-20 9:15 ` John Garry
2021-01-20 10:19 ` Joakim Zhang
2021-01-21 20:31 ` Arnaldo Carvalho de Melo
2021-01-21 21:40 ` John Garry
2021-01-20 12:56 ` Jiri Olsa
2021-01-20 13:07 ` John Garry [this message]
2021-02-05 9:56 ` John Garry
2021-01-20 21:42 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d064a9b-bbb6-4ef9-b959-d64c14850319@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®