Re: [PATCH 1/2] dt-bindings: usb: mediatek,mt6360-tcpc: add ports properties

[Macpaul Lin <macpaul.lin@mediatek.com>]

On 10/16/24 04:54, Rob Herring wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Tue, Oct 15, 2024 at 06:33:36PM +0800, Macpaul Lin wrote:
>> Add 'ports' and sub node 'port' properties to specify connectors on the
>> High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines
>> endpoints of the USB controller.
>> 
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>  .../bindings/usb/mediatek,mt6360-tcpc.yaml    | 21 +++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> index 053264e60583..5b6ea0d734ea 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> @@ -32,6 +32,27 @@ properties:
>>      description:
>>        Properties for usb c connector.
>>  
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +    description:
>> +      Any connector to the data bus of this controller should be specified.
>> +    properties:
> 
>> +      "#address-cells":
>> +        const: 1
>> +
>> +      "#size-cells":
>> +        const: 0
> 
> No need for these, already defined in the $ref'ed schema.
> 
>> +
>> +    patternProperties:
>> +      "port@[0-2]$":
>> +        $ref: /schemas/graph.yaml#/properties/port
>> +        description:
>> +          It could be one of the following interface types. High-Speed
>> +          (HS) data bus endpoint to the Type-C connector, SuperSpeed (SS)
>> +          data bus endpoint to the Type-C connector, or Sideband Use (SBU)
>> +          AUX lines endpoint to the Type-C connector for the purpose of
>> +          handling altmode muxing and orientation switching.
> 
> You have to define what each port number is.
> 
> However, I'm completely confused as to why you need any of this. The
> description sounds like the usb-c-connector which is already defined as
> a child node.
> 
> Rob
> 

After checking the internal reference DTS, I've found the
intent was wrong for these ports. I'll send [2/2] of v2 for the
DTS update. Hence this change to DT Schema is no longer required.
Please drop this patch.

Thanks!
Macpaul Lin