From: Andrew Lunn <andrew@lunn.ch>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
o.rempel@pengutronix.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for lan8842
Date: Tue, 22 Jul 2025 15:08:08 +0200 [thread overview]
Message-ID: <0d0b56bd-6a8e-4179-955d-bc0e2a933b20@lunn.ch> (raw)
In-Reply-To: <20250722060954.ecaxrk7vq5ibuy55@DEN-DL-M31836.microchip.com>
> Yes, I will use PHY_ID_MATCH_MODEL().
> I was thinking to start with 2 cleanup patches, one to use
> PHY_ID_MATCH_MODEL in the driver and one to introduce
> lanphy_modify_page_reg and put it to use.
> Do you have other suggestions?
I did not look at the driver too closely. There might be other
cleanups you can do, but those two make sense in the context of what
you are doing.
Andrew
next prev parent reply other threads:[~2025-07-22 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 7:14 Horatiu Vultur
2025-07-21 14:22 ` Andrew Lunn
2025-07-22 6:09 ` Horatiu Vultur
2025-07-22 13:08 ` Andrew Lunn [this message]
2025-07-23 5:34 ` Oleksij Rempel
2025-07-23 9:01 ` Horatiu Vultur
2025-07-23 10:48 ` Oleksij Rempel
2025-07-23 14:28 ` Andrew Lunn
2025-07-24 6:25 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0b56bd-6a8e-4179-955d-bc0e2a933b20@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®