mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Aditya Garg <gargaditya08@live.com>
Cc: Orlando Chamberlain <orlandoch.dev@gmail.com>,
	Mark Gross <markgross@kernel.org>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Lukas Wunner <lukas@wunner.de>,
	Seth Forshee <sforshee@kernel.org>,
	Aun-Ali Zaidi <admin@kodeit.net>,
	Kerem Karabay <kekrby@gmail.com>
Subject: Re: [PATCH v3 0/5] apple-gmux: support MMIO gmux type on T2 Macs
Date: Wed, 1 Mar 2023 13:56:05 +0100	[thread overview]
Message-ID: <0d0e0ca7-5d49-dab9-0f1b-eee30c3360d4@redhat.com> (raw)
In-Reply-To: <BM1PR01MB093194DDA465CE8D9F081A05B8A59@BM1PR01MB0931.INDPRD01.PROD.OUTLOOK.COM>

Hi,

On 2/21/23 20:07, Aditya Garg wrote:
> Hi
> 
>> Currently the backlight registration in apple-gmux.c is unconditional
>> (if a GMUX is detected).
>>
>> I have attached a patch to make it honor the acpi_backlight=xxx
>> kernel commandline option like most other x86/ACPI backlight drivers
>> do, please give this a test.
>>
>> Regards,
>>
>> Hans
> 
> I had to modify the patch a bit to make it apply alongwith the gmux patches by Orlando, and the bug seems to be fixed now.
> Attaching the patch I applied with this email.

Yes I didn't have Orlando's patches in my tree when preparing this.

Thank you for testing this. I'll rebase the patch on top of Orlando's
patches once those have been merged and then officially submit
it for review + merging.

Regards,

Hans


  parent reply	other threads:[~2023-03-01 12:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21  9:24 Aditya Garg
2023-02-21 12:31 ` Hans de Goede
2023-02-21 19:13   ` Aditya Garg
2023-02-22 18:13     ` Aditya Garg
     [not found]   ` <BM1PR01MB093194DDA465CE8D9F081A05B8A59@BM1PR01MB0931.INDPRD01.PROD.OUTLOOK.COM>
2023-03-01 12:56     ` Hans de Goede [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-02-18 13:20 Orlando Chamberlain
2023-03-01 12:54 ` Hans de Goede
2023-03-03  7:54   ` Orlando Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d0e0ca7-5d49-dab9-0f1b-eee30c3360d4@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=admin@kodeit.net \
    --cc=gargaditya08@live.com \
    --cc=kekrby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=markgross@kernel.org \
    --cc=orlandoch.dev@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sforshee@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®