From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63CB0C4167B for ; Mon, 4 Dec 2023 14:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234314AbjLDOlu (ORCPT ); Mon, 4 Dec 2023 09:41:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233871AbjLDOlt (ORCPT ); Mon, 4 Dec 2023 09:41:49 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4459ED7; Mon, 4 Dec 2023 06:41:54 -0800 (PST) Received: from kwepemm000007.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SkR8V5xhxzShbk; Mon, 4 Dec 2023 22:37:30 +0800 (CST) Received: from [10.67.120.192] (10.67.120.192) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Dec 2023 22:41:51 +0800 Message-ID: <0d0e0fc4-ff7c-4e54-8fe6-2a5754cf7910@huawei.com> Date: Mon, 4 Dec 2023 22:41:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , Subject: Re: [PATCH V2 net 1/2] net: hns: fix wrong head when modify the tx feature when sending packets To: Wojciech Drewek , , , , , , References: <20231204011051.4055031-1-shaojijie@huawei.com> <20231204011051.4055031-2-shaojijie@huawei.com> <5db8b856-27fe-41df-82df-774a3ec312a7@intel.com> From: Jijie Shao In-Reply-To: <5db8b856-27fe-41df-82df-774a3ec312a7@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.120.192] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm000007.china.huawei.com (7.193.23.189) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on 2023/12/4 18:15, Wojciech Drewek wrote: > > On 04.12.2023 02:10, Jijie Shao wrote: >> From: Yonglong Liu >> >> When modify the tx feature, the hns driver will modify the > Upon changing the... > >> maybe_stop_tx() and fill_desc() functions, if the modify happens >> during packet sending, will cause the hardware and software >> pointers do not match, and the port can not work anymore. >> >> This patch deletes the maybe_stop_tx() and fill_desc() functions >> modification when setting tx feature, and use the skb_is_gro() >> to determine use tso functions or non-tso functions when packets >> sending. > and use the skb_is_gro() to determine which functions to use in the tx path. >> Fixes: 38f616da1c28 ("net:hns: Add support of ethtool TSO set option for Hip06 in HNS") >> Signed-off-by: Yonglong Liu >> Signed-off-by: Jijie Shao >> --- > Some commit msg suggestions, other than that: > Reviewed-by: Wojciech Drewek > Thanks， commit msg is refined in v3 Jijie