mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Andreas Hindborg <nmi@metaspace.dk>, Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org,
	Hans Holmberg <Hans.Holmberg@wdc.com>,
	Matias Bjorling <Matias.Bjorling@wdc.com>,
	Niklas Cassel <Niklas.Cassel@wdc.com>,
	kernel test robot <lkp@intel.com>, Jens Axboe <axboe@kernel.dk>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] block: ublk: enable zoned storage support
Date: Thu, 2 Mar 2023 17:19:20 +0900	[thread overview]
Message-ID: <0d0e5c63-a155-d2ad-1829-c016c61acad6@opensource.wdc.com> (raw)
In-Reply-To: <87o7pblhi1.fsf@metaspace.dk>

On 3/2/23 16:31, Andreas Hindborg wrote:
>>> +struct ublk_param_zoned {
>>> +	__u64	max_open_zones;
>>> +	__u64	max_active_zones;
>>> +	__u64	max_append_size;
>>> +};
>>
>> Is the above zoned parameter enough for future extension?
>> Does ZNS need extra parameter? Or some zoned new(important) features?
> 
> @Damien, @Hans, @Matias, what do you think?

Yes, add some reserved fields. The struct is 24 B for now, you can make it 32 B.
But it is a little odd: why 64 bits for max open/active zones and max append ?
bio len is 32 bits and number of zones also 32 bits. You do not need 64 bits for
all these fields. Also, no zone model reported with this ? What about write
granularity (for SMR HDDs) too ?

So something like:

struct ublk_param_zoned {
	__u32	model;
	__u32	write_granularity;
	__u32	max_open_zones;
	__u32	max_active_zones;
	__u32	max_append_size;
	__u8	reserved[12];
};

looks better to me. Note sure about the need for model and write_granularity
here though. I did not follow zoned ublk patches.


-- 
Damien Le Moal
Western Digital Research


  reply	other threads:[~2023-03-02  8:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 20:05 Andreas Hindborg
2023-02-27 10:20 ` Niklas Cassel
2023-02-27 11:59   ` Andreas Hindborg
2023-02-27 14:29     ` Niklas Cassel
2023-02-27 14:41       ` Andreas Hindborg
2023-02-27 15:20 ` Minwoo Im
2023-02-27 15:36   ` Andreas Hindborg
2023-02-28  9:52 ` Hans Holmberg
2023-03-01  7:28   ` Andreas Hindborg
2023-03-02  2:50 ` Ming Lei
2023-03-02  7:31   ` Andreas Hindborg
2023-03-02  8:19     ` Damien Le Moal [this message]
2023-03-02  8:32     ` Ming Lei
2023-03-02  9:01       ` Ming Lei
2023-03-02  9:14         ` Ming Lei
2023-03-02 10:07           ` Andreas Hindborg
2023-03-02 13:16             ` Ming Lei
2023-03-02 13:28               ` Andreas Hindborg
2023-03-03  2:59                 ` Ming Lei
2023-03-03  8:27                   ` Andreas Hindborg
2023-03-03 11:47                     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d0e5c63-a155-d2ad-1829-c016c61acad6@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=Hans.Holmberg@wdc.com \
    --cc=Matias.Bjorling@wdc.com \
    --cc=Niklas.Cassel@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=ming.lei@redhat.com \
    --cc=nmi@metaspace.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®