From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48EAC302750 for ; Tue, 18 Nov 2025 13:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763472956; cv=none; b=aDWCLo94CbyAoV+wFhHInhq+94I63TT0Y0GoFsaSKKklBZSdludvuv5KIt4m2RYb1oWns5rEyb92K6G8AGkI3+ptzsmq4WiXJqMLFTWO2NGUOsdzLRdq01iqOHy7za3bazZSN3BZqXtE/HUqnQX2a32gXY9NMMT3ZBGMVJCCplU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763472956; c=relaxed/simple; bh=qB9ZhelquLeX/47JmPfyRupStQRSoMTp6VRGQjPcEAI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GwoQRFEPhyvNcIEVdYcREjae1HsZOG7NwDe5MoLRi4SnFZH/mBaZtd92jBTB7t9ngKw2EAxZGsiO1HdW35F86Ol9YKKntHXM1Y0bdWBuyN5C/dgYsgKyyxDg0Wv8snDDItlAYrRd//eUoHThC68zwKeCi1kbp0R6ajXt7tdIfdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dwiZvw1p; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BUNtCT1j; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dwiZvw1p"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BUNtCT1j" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AI6fxCJ2343970 for ; Tue, 18 Nov 2025 13:35:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KnPI+HvRCXHtDrr9MXHrsjdWCFalSnw5mTh9evIOeJM=; b=dwiZvw1pSJE/Grhw HJLYohoJE/tE3hqI2z9myan7EXkTKrpsrp5iiWmH2eWqe/p6LTvD57U3Zj80KZY+ pszgS1llZ5I6c1r8vGXWQzcMdl3EbzGvYzVRUbz1x1IUFbYfz/CsSjLwY68jnyEI dvAr+rgwTNMCedd87Xhef8v8jprP0wYcrqmCUsSgEFr1Ra21sVdUN0Xy4AW0GoRu 4xNmEhEQ7CSgTtIkT4VRvXx6ZQLnGwU2ul4Cnc5ujy88ZUQ1G/nxokjQgdTL/oe8 7it8ld9jgLeQmF+5I+JCCyRElF4Y6sNqRVF0/e3NPuCglFFILhkHRYhQ64/RhAIm 4xWBeg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4agkrn15wf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 13:35:53 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee24e1559aso4368601cf.3 for ; Tue, 18 Nov 2025 05:35:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763472952; x=1764077752; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KnPI+HvRCXHtDrr9MXHrsjdWCFalSnw5mTh9evIOeJM=; b=BUNtCT1jnEpRoA2s2J8/o8WfkbYYWrX/NDXHxjYS7d8gbpzX3QywnW2Ip1V1iNXutg Bw8kcxlDwL+OL7eUXudXWfw7t32LIVH+1oYMHr8hu9c4n9q/mykEH+YDqxpAfHV91ItI VHC+K1q70a5fsV6X0vZCkgH61MI+z2OhG7oiWWSSo/BGTGZ7RDutq8rBQ884f3A4RJpN O+0lWWQ1bWOo2mo8yYFs/rjOxJCgVq4QjPdIT8kgURS4ZEmH8LUYVeEZnyd8v2IZ3+SU x9stDB6bV+mY2HP50yOxhNJOCWK+XENGvFLv51ej1EtG7Os0bxiJpE0hu6lfGf4g96Cg 2SXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763472952; x=1764077752; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KnPI+HvRCXHtDrr9MXHrsjdWCFalSnw5mTh9evIOeJM=; b=xOYUmsyWQXxPUo2AfAdJBAdJu6LeKe/zIpc21lDxZ0msiNIGlpR8BJ12J/HjZp1qZ1 SCugZuqrf5f9LtpwCstcr3Mjwh5W2psqUpFEUx70S+kCCCWQqyuAYvz75BcJba48uIIJ QY9raR/2jneGXIWqeJwfj0zCpfs+zPHbaGwa8YAtsLkaaEVfN2AKypLjS9yqZ0N5SoQc pNrNjcF5jc0UGsGd8NECa6cRSxP28ZrYbzK65/pX7/xJhB9yGX6EXR1kIdjN8lhOqFVG Ys4tuZ1ic2lnDqukvR0sFkGgoxUNU01gGPSY7khh+blrX2FvEjcGLTMcfhpnMDJ4/HK+ deEQ== X-Forwarded-Encrypted: i=1; AJvYcCVk7wpAjlGIParB46FxOjU246vrxNTim1jpHqYQtvaH+V1E1yU33hYhumnpOP1N0vO8lA7aKnIcQBPada8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7r/KSW+SGBy1BtlOBmy2zIRA6pU/tSndtBm7WozvZ4CKPu+ke EJ/wdv68yZAplG44l/3JDyJbXh0WhaLdGGvmI2C7+Fpvt35dRJFkyGNM/YhwMwKl+LHkndpuNCm CJmURW2lmzCmIasRIVuNqQeyw7vNDUmoKualJC6jthOvF0HHeexRxT32CG52ALi+rfI+sjv/PtJ 0= X-Gm-Gg: ASbGncuGfF5LKCYCY06IQfzwuc1UVUqTO/IaIG0tJ2+gFjiZjxrn2p8TYguMbemRLmf 8RSefiHnIAm8k7FsPIAMgHKq1PpTOQtURHy3J5aqmHTTw6ymz29uWZzv5xE4Xd4P04TjqexOF6l HzWm/WrfMtttP/ZX77i1wOuTT4ji7FhDao3sYEXHDS0PRkn0iWq6UQosLcXuJYPk0q/oADjqQoT oaecCKVO31MD6T9VGaHZa+SVY2sMHg0Y4jLoCbMzcF9x6qJzWdF8Xxhd4uJg6VveVIaRYBKwhFI Rku7BUHWef3IFXEQVvFil07uczieYkX/OBRpTYGeXA752mgM2aS80sd7SKv2+bpOINJB1YTUK8Q E7SrYRqjiRW92mB6idxQx59qS5d9jOj10sipvK8kEtwX4OFbB9TBEJ0VcamJKr024N/k= X-Received: by 2002:a05:622a:1a19:b0:4ee:1063:d0f3 with SMTP id d75a77b69052e-4ee317fa73emr26551711cf.11.1763472952280; Tue, 18 Nov 2025 05:35:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGY1KZXSYMRxPN6HY6CHGoASb9AG9wqGfmmmqFipQhKzeaiMu/659NOr1Ib5Am/aZalUkf8vw== X-Received: by 2002:a05:622a:1a19:b0:4ee:1063:d0f3 with SMTP id d75a77b69052e-4ee317fa73emr26551291cf.11.1763472951811; Tue, 18 Nov 2025 05:35:51 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734e9e0f20sm1371741666b.0.2025.11.18.05.35.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 05:35:51 -0800 (PST) Message-ID: <0d0e85b1-a70f-430d-b75f-a74cd19f9895@oss.qualcomm.com> Date: Tue, 18 Nov 2025 14:35:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: adreno: fix deferencing ifpc_reglist when not declared To: Akhil P Oommen , Neil Armstrong Cc: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251117-topic-sm8x50-fix-a6xx-non-ifpc-v1-1-e4473cbf5903@linaro.org> <04aec988-59ba-4c98-b922-510d86b10ea5@oss.qualcomm.com> <1488f09b-63b7-4412-ba56-28b1c81528ac@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: jKefk67FuUrbTpod6nV5wCUJkf783il_ X-Proofpoint-ORIG-GUID: jKefk67FuUrbTpod6nV5wCUJkf783il_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDEwOCBTYWx0ZWRfX1Vm5wiDXfurQ zWgO2u0oOWeLO1oUwE5k+Os9glklsKHDbpMlHCmhG4SIM3QdSBL1pDER7jY0tqVSHhBhkt79ghl T+JmZfkVegs9XGN2th5plSAgYZXidjEE8R1RkBfqUn7i1py96Tkt8XxqvPHRb/Mr9U2OkuNmZBl BcnemmVkwNd7p1P/bm6qqGP93wfu9geI/OoXq3yD0bnSkDUaWFF7FLa2o76hI/X/Ih3xevhGRGE qPnHRKm0cbf68t2XtIpVxcQr5AONBIbwsFePrKz/H/lT7LpLCBPA7reJJfUPYhI53AUF20DdC1m UQ936DXN03zx16amQZMv3v3SI5HCLwI9RLzvKhTbd2ns3S0dz8cEbnSwHUwvex3Ck6MzUw3w+X2 gyhFDupZ2LWZlBe+WT8kPYm85nOTpA== X-Authority-Analysis: v=2.4 cv=L+kQguT8 c=1 sm=1 tr=0 ts=691c7639 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=sUuaTTKWZZLiqq4pnuYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_04,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180108 On 11/18/25 8:47 AM, Akhil P Oommen wrote: > On 11/17/2025 9:17 PM, Neil Armstrong wrote: >> On 11/17/25 16:02, Konrad Dybcio wrote: >>> On 11/17/25 3:51 PM, Neil Armstrong wrote: >>>> On plaforms with an a7xx GPU not supporting IFPC, the ifpc_reglist >>>> if still deferenced in a7xx_patch_pwrup_reglist() which causes >>>> a kernel crash: >>>> Unable to handle kernel NULL pointer dereference at virtual address >>>> 0000000000000008 >>>> ... >>>> pc : a6xx_hw_init+0x155c/0x1e4c [msm] >>>> lr : a6xx_hw_init+0x9a8/0x1e4c [msm] >>>> ... >>>> Call trace: >>>>    a6xx_hw_init+0x155c/0x1e4c [msm] (P) >>>>    msm_gpu_hw_init+0x58/0x88 [msm] >>>>    adreno_load_gpu+0x94/0x1fc [msm] >>>>    msm_open+0xe4/0xf4 [msm] >>>>    drm_file_alloc+0x1a0/0x2e4 [drm] >>>>    drm_client_init+0x7c/0x104 [drm] >>>>    drm_fbdev_client_setup+0x94/0xcf0 [drm_client_lib] >>>>    drm_client_setup+0xb4/0xd8 [drm_client_lib] >>>>    msm_drm_kms_post_init+0x2c/0x3c [msm] >>>>    msm_drm_init+0x1a4/0x228 [msm] >>>>    msm_drm_bind+0x30/0x3c [msm] >>>> ... >>>> >>>> Check the validity of ifpc_reglist before deferencing the table >>>> to setup the register values. >>>> >>>> Fixes: a6a0157cc68e ("drm/msm/a6xx: Enable IFPC on Adreno X1-85") >>>> Signed-off-by: Neil Armstrong >>>> --- >>> >>> I think it should be fine to skip calling this func altogether >>> if !ifpc || !pwrup_reglist >>> >>> Although ifpc && !pwrup_reglist should probably scream very loud > > That's correct. It is a weird combo. > >> >> Sorry but why? pwrup_reglist was introduced way earlier than IFPC. > > Pwrup list is shared with preemption feature too. And preemption support > was introduced before IFPC. Sorry, I somehow erased that from my memory Konrad