From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: YuTong Chang <mtwget@gmail.com>, bcousson@baylibre.com
Cc: tony@atomide.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ARM: dts: am33xx: Fix MMCHS0 dma properties
Date: Mon, 20 Jun 2022 14:32:55 +0200 [thread overview]
Message-ID: <0d0ef565-9579-31ca-7f9a-7b3c0e7bc090@linaro.org> (raw)
In-Reply-To: <20220620121900.5196-1-mtwget@gmail.com>
On 20/06/2022 14:19, YuTong Chang wrote:
> According to technical manual(table 11-24), the DMA of MMCHS0 should be
> direct mapped.
>
> Signed-off-by: YuTong Chang <mtwget@gmail.com>
This should be v2, not v1. You already sent a v1.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> v1: Cleaned up coding style and addressed review comments
>
> arch/arm/boot/dts/am33xx-l4.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
> index 7da42a5b959c..7e50fe633d8a 100644
> --- a/arch/arm/boot/dts/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/am33xx-l4.dtsi
> @@ -1502,8 +1502,7 @@ SYSC_OMAP2_SOFTRESET |
> mmc1: mmc@0 {
> compatible = "ti,am335-sdhci";
> ti,needs-special-reset;
> - dmas = <&edma_xbar 24 0 0
> - &edma_xbar 25 0 0>;
> + dmas = <&edma 24 0>, <&edma 25 0>;
> dma-names = "tx", "rx";
> interrupts = <64>;
> reg = <0x0 0x1000>;
Best regards,
Krzysztof
prev parent reply other threads:[~2022-06-20 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 12:19 YuTong Chang
2022-06-20 12:32 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0ef565-9579-31ca-7f9a-7b3c0e7bc090@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mtwget@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®