mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Walker Chen <walker.chen@starfivetech.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v1 3/3] riscv: dts: starfive: add tdm node and sound card
Date: Thu, 30 Mar 2023 16:31:30 +0100	[thread overview]
Message-ID: <0d108d6c-e892-418b-b9af-6c2dd133dd71@spud> (raw)
In-Reply-To: <2d5a8dae-73fd-b1f8-089e-041637d66b0d@starfivetech.com>

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

On Thu, Mar 30, 2023 at 11:16:08PM +0800, Walker Chen wrote:
> On 2023/3/30 15:58, Conor Dooley wrote:

> > Excuse me for not following here, but Walker, could you point me at
> > where in the schematic for the VisionFive 2 that this wm8960 actually
> > is?
> > I know ~nothing about audio, but good old Google tells me that this is a
> > dedicated codec chip and I was looking at [1] and could not easily find
> > it on the schematic.

> > 1 https://doc-en.rvspace.org/VisionFive2/PDF/SCH_RV002_V1.2A_20221216.pdf

> The TDM need work together with external codec WM8960 by plugging the raspberry pie
>  audio board into the 40-pin, which is found in sheet 21 of the schematic. Because the
>  40-pin of VisionFive2 is fully compatible with the pins of Raspberry pie audio board. 
> 
> For more information of the audio board, you can take a look at the following webpage:
> https://wiki.seeedstudio.com/ReSpeaker_2_Mics_Pi_HAT/
> 
> The schematic of audio board:
> https://files.seeedstudio.com/wiki/MIC_HATv1.0_for_raspberrypi/src/ReSpeaker%202-Mics%20Pi%20HAT_SCH.pdf

Ahh, I feared that this was the case. If it's not on the board, then it
shouldn't be in the dts (and certainly nothing should be in
jh7110.dtsi!).
I suppose this should be a dt-overlay, but I don't know anything about
the upstream infrastructure for those. Nor do I know what is permitted
in terms of overlays.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-03-30 15:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 15:33 [PATCH v1 0/3] Add TDM audio on StarFive JH7110 Walker Chen
2023-03-29 15:33 ` [PATCH v1 1/3] dt-bindings: sound: Add TDM for " Walker Chen
2023-03-30  7:39   ` Krzysztof Kozlowski
2023-04-03 12:17     ` Walker Chen
2023-03-29 15:33 ` [PATCH v1 2/3] ASoC: starfive: Add JH7110 TDM driver Walker Chen
2023-03-29 15:33 ` [PATCH v1 3/3] riscv: dts: starfive: add tdm node and sound card Walker Chen
2023-03-30  7:43   ` Krzysztof Kozlowski
2023-03-30  7:58     ` Conor Dooley
2023-03-30 15:16       ` Walker Chen
2023-03-30 15:31         ` Conor Dooley [this message]
2023-04-03 12:58     ` Walker Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d108d6c-e892-418b-b9af-6c2dd133dd71@spud \
    --to=conor@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --cc=walker.chen@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®