From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 248783F1ABE; Tue, 19 May 2026 11:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779191804; cv=none; b=EuI9IxjIJTrPcdjlrINV8dzU0Fmt5Nm3qaP7s4GcFe7D4qIyGB6AUhtK1DkBckYzveReJsARk3xC3dzmgKD4E6NN6/qZcezpdzyxkMylK7o08+O6u9InM+04Hge2E46C0vbytVAMXQhx2XURCp7w52+K0htNopuhFZVppVgYBBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779191804; c=relaxed/simple; bh=bQhKVL6qQMcUeyt6B+f8lMfTGX8DOTIkacSNevKWc40=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=emTpC1Sabaq+7Q5K3pVC2Ay7dNEC9yDLy2cxgL+KYzhlzzeOMug4ro3XuvFJfAff2egUJ6QtMiMNQjvBOcYh6sCuJguAkadIwNyG76h5nb0T5k7KvKYbHpAuw0oVAyVA69iXkK1WNX1QI20fevwEVTKzSwaXNSKV0IIVb169KZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=DQbMI/ig; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="DQbMI/ig" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ijR1bXan0D5bPjUwJSQ6AnjGs2pf347H7WrT7ZWyeMQ=; b=DQbMI/igPGT5Urim3E+Fc3Vk7Z oJb1lo179wf2RJT8bySyp92xFiPGxqqCEx5ALrnOgicG2l8B6hc0zpH3cTrSoXV1mD+4bwnDtlxV6 9l6DM+86YJ6wR/T66g0zVxuM9bgsW9Sm+W0FhFMohKK/flQqoWzo/zfFkfhviuesndjI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wPJ3f-003eom-O8; Tue, 19 May 2026 13:56:23 +0200 Date: Tue, 19 May 2026 13:56:23 +0200 From: Andrew Lunn To: Nicolai Buchwitz Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Oleksij Rempel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2 1/2] net: phy: honor eee_disabled_modes in phy_support_eee() Message-ID: <0d11744b-e235-437d-b14d-3b49e0e162ef@lunn.ch> References: <20260518-devel-phy-support-eee-fix-v2-0-05b52626fa68@tipi-net.de> <20260518-devel-phy-support-eee-fix-v2-1-05b52626fa68@tipi-net.de> <05a24b73-ff89-41e2-a655-224f1c2dbc31@lunn.ch> <7245b9c6294300265636ad954c01c248@tipi-net.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7245b9c6294300265636ad954c01c248@tipi-net.de> On Tue, May 19, 2026 at 08:20:02AM +0200, Nicolai Buchwitz wrote: > Hi Andrew, > > Thanks for your review. > > On 19.5.2026 04:19, Andrew Lunn wrote: > > On Mon, May 18, 2026 at 10:23:09AM +0200, Nicolai Buchwitz wrote: > > > phy_support_eee() copies supported_eee into advertising_eee > > > unconditionally, overwriting any filtering applied during phy_probe() > > > based on DT eee-broken-* properties or driver-populated > > > eee_disabled_modes. > > > > Sorry, i should of questioned this on v1. What PHY are you using which > > masks advertising_eee in probe? It seems like this is wrong, and it > > should be setting >eee_disabled_modes, or maybe eee_supported.c > > The masking isn't PHY-specific. phy_probe() applies eee_disabled_modes > to advertising_eee after of_set_phy_eee_broken() picks up the > eee-broken-* properties from the PHY DT node. Ah, O.K, i understood that wrongly. But you do say phy_probe(), not PHY probe(), so it was my error. Andrew