From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932582AbcJLJVx (ORCPT ); Wed, 12 Oct 2016 05:21:53 -0400 Received: from mail-co1nam03on0055.outbound.protection.outlook.com ([104.47.40.55]:62808 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932105AbcJLJVn (ORCPT ); Wed, 12 Oct 2016 05:21:43 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [patch] drm/amdgpu: potential NULL dereference in debugfs code To: Dan Carpenter , Alex Deucher , Tom St Denis References: <20161012061730.GP12841@mwanda> CC: David Airlie , Chunming Zhou , "Monk Liu" , Junwei Zhang , Jammy Zhou , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <0d178bc4-49e3-4073-2ccc-d0d196d6f5db@amd.com> Date: Wed, 12 Oct 2016 11:20:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161012061730.GP12841@mwanda> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:a462:f0a8:bb07:e87a] X-ClientProxiedBy: VI1PR07CA0102.eurprd07.prod.outlook.com (10.165.229.156) To BN6PR12MB1298.namprd12.prod.outlook.com (10.168.227.148) X-MS-Office365-Filtering-Correlation-Id: 22c5026a-3352-4347-b1e3-08d3f28111b1 X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;2:/dgKOKvu7V9o9HwDU9GVfSpXORfxRQHmFSSrjt1GGlZQA2aXUn3xrCAXj3BCSAEOKBcoayA9SUY1uMbFOvAuD22Dbg056TfrE337IR1R23zlt5j3a6ylplnYeVUQnTGa27SUGxjHw92Ks3RW2lzZkzL8+KakRTIIKxH9gX01eGtMccGQk0lQe/gXrQkIXxH83BNBpZ6+MJ76v2GngwqfvA==;3:EWZ3ZURCCelK/oyNa2eZ9+5+Cbcq58PWeXYvR9XeUrQc4h8vZJTy4kENnsTCrIxQ6kEBaXlIgQFuzyn4LQQAoLMyxpSybK/ojN9QTr75yk3Kx5j7g0DB2NJOd8a4D6uo6Lzh799rENopxIZvUTk8rg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;25:sBMGadE6hAo/sInJBVAlvim3IDQXCC9teqnrrzlztQRRMs+17ByHYJhpspKEAQSo2ei5Mu6tCVVe/pvUals/vMS6DMOPTVrdCszrNFAi0ZJ89EASgXgB3a+mPWIa5Q9GSdHehDVGpDjk0OheDL5t3HFoegIe2Ds078bWI/JW1kEkf3Rzgqw5Utihqx2A1mA6jaRJXtjJSjwiafxRjmA8fq55XrmYJ693U2CZBsLlWRHeuvyePafyAC11wzGsZMosaAgBE9fY8d/t2/6fbkBgjGWBqxCGpOLgHu83oVFRBTw/BdNp+NHDFPK4K/sjGEVIGAIos9spEu0yHtEtAFCl+IVKAuYIqaVB/77TPlxdkysky2Jr6nBbKtD2VNFELoC3Y3+CjJOaZaUXBAc+NlmShU2USUQ9ClX1x0lBlpVisrvKn8Lk5Cok9xs1BOxtddmtZbO4ql6iUqiEodq8DxKYcKOkWZqj2kLhVQMj23tM7dPf+v2ZuF6ZU1G3FBYYnzWadEeTWkiyFhU0ihNSDAI8KDVrUdq63pFbi7xibQxgsdzSTlqLhiLjvAQc+l4s7HT8LcEEqX2qGSNiPEf94OcpPOMDy51fe65hmWE4jXnjMBgIFojsyoV/bqVr+6/Szb05yjIsm2Wi6WrIm6pNk4KlKDGeXoKEZRQUjq1E/NiVH5afvvqrUQRHk2ek1EGhQTPuT++NAadzxfLV+pSyt/GMgNDVq2yEzY3JXpdphHdDVUt4LbIO4LILh0wNmLBZsX+C1ZmPJRzY6z7/oCBVkB6Hnw== X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;31:Re5DRb1+Gfa/DSFsleE59yF859yDSY75HuKH0adWzFl4/UEm1552q/XSQ58G3+fFWxBwjX10n2UvpiDxpAu3TAaAnJgzQQG1duyMrTmbmhRpGl8wtaWnfusrDooaA5XuJYD/QXTuxCN4dJa9ij0wy8v6jll64Yuvztq4RdJrm8wZ1yGb+VMM8IpYE41wuU8M7QLyR474WhZp28aYXqu0PLBL38au1aNPkotODdEWzpg7ArLH8plwc4wnkpzwu5zG;20:t0A91sFh8zvIjk/5ihl/mqAgbTW2QQbhj/z7RRPSguOQgne/mdUg6Fe4DDqK6U+6LoQDNb5/D086Onz27ohCFli0sv0T4Cl+1aSu15o1lkFB2eC3flM1V3Ie5kjccvl6Ms1fDtkEriXmi6MuJyl5rsrmwtxyNnVUpqLSPAxgjLtwT18D86ZoJ9sWwVaOzLl1scOIZWYKrvkSuUOPfSjdcFfVTUVRpK0/qNdtBLpSr716OV362aLReYr1mhpUgM/HdbdwJ5HE03sA7DR/dY3t789b4tgqtUkNXSlOEGof8WS7r3lvNg/BfKmzLsLERDYZqpis+Rw0ZQhkbx4zt6mAzdrZg9cRMuADkYxpaFSgg/Ed8Tsrc9hVQCHruKHAEP+LWzln+gDBNTooC4HtOBni/g6w5dlVnQeh1PQzGfGQY5qtI+2o6Qz1N5U38eu5IXXVC4c/QgkKhjtoskVkm1mVYMGahRTZQ5b9DHz8rq9xrVanlNnLW4eM6+FuJdMjNmfT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;4:FHJ+sidkL8PN9/i7VvM/KjP1iR3Oo/J6eljcubeT8KaXNZjcsOIhQfS3V2rGTTrVEumcmpUNgF0ex94N1nvhsXsNAgxEdVAy4qOZoMnPdnZXSMpd+8bKV3BQM8fUX9Bdz/23O5AUnP0OX8Uu16UaUD8ikLjrIDGTtH/Zm9f5to4lOJIGaAcPAIa9kHG0oNWl121NSj+QOKGld4OhtfAkf9p0HQgFQ1m+E36peAJUDv3e3j/1VFsxobDrRxIV5EVaqZ1wWKh1bq5p28meiIKBrEam9isD4nYhW7j1FeNWtgKWOHzLi3s6Y9abC8CumQ2ODTcfiQ6tYeP1C19Jkg8JUIy8pzEXoYZp+yv9pqnxIVSgMHmE/SB0ohq8qOc+RpQqRwazF+UmCfGuMl38LImwCKM8gWCbllGERIlR420uOFR6maE46PNbMDWkcWupwDxNVk4FmUCBLw5u9Gb6IZj5oufZYtiMjqE1rnLi/PSV8YQ8HkjVxI+DTy24HE8ewYS3 X-Forefront-PRVS: 0093C80C01 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(54356999)(4326007)(76176999)(2870700001)(19580395003)(575784001)(6636002)(64126003)(2906002)(33646002)(86362001)(101416001)(6116002)(42186005)(19580405001)(92566002)(2950100002)(106356001)(1706002)(77096005)(31686004)(6666003)(50466002)(50986999)(586003)(305945005)(31696002)(7736002)(36756003)(7846002)(5001770100001)(65826007)(5660300001)(83506001)(105586002)(68736007)(23746002)(4001350100001)(65806001)(8676002)(47776003)(65956001)(189998001)(81156014)(81166006)(97736004)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:[IPv6:2a02:908:1251:7981:a462:f0a8:bb07:e87a];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR12MB1298;23:HozpMrCH23fhF0OsNCcgjDWXpXAO3ulIqVcBr?= =?Windows-1252?Q?leYDUnc47MsPY28DRmfLjAcZavdqhcf+K/iCVhMO2+vFn+9qulmkWJIh?= =?Windows-1252?Q?LLlgrDnk6deILpC7REiXwqCMhBwj8FjJXbgO/efsrYxRLq5p2NHveks7?= =?Windows-1252?Q?T8Q7SQfo9oDGOaeLOYXcFsTffHnvjf0c9e28IMXaRaRtha4L9q87EwM0?= =?Windows-1252?Q?fIEC/W8loio2arsqRYWlooSjzOr1Rcp0z+OVRNhdZdAqteK4POk96ccB?= =?Windows-1252?Q?9kbxKWcxKL37/f3YDR7wq9D53XO7af7VkvpbE4Ga1d6o179f4o9TDRp7?= =?Windows-1252?Q?6ny0AezuUjNi1QS8eB0aHTicPbqlKbz6bDz35fMK1psfrvrFMKh6pPyk?= =?Windows-1252?Q?pMuYVo1VazKM9VouUMT6FGSmGPwe4qF9NdgBO+FNxbBHT3W/2vFP3C5T?= =?Windows-1252?Q?WO7crwoAGy7yPHvqYnLiKySpu3cFhhfbcDNffsCMEgovjJ/yhY+aIKoj?= =?Windows-1252?Q?o6BGmQ3vVz7BEMpeq1assZUw1yMWmGA8dYBNtrE4Vo6ZbpGXtTA+2Z/3?= =?Windows-1252?Q?8v1V7lXjIRS86Fz6NO+LSUujbiiJBb2eb5WiDqp3syJaUYhsCXzQQKcw?= =?Windows-1252?Q?iUAOWnX7B3KCTWQgWykBKhn4oJwPhXjNjIjTmyoi1n1PuAbNKaDy37jz?= =?Windows-1252?Q?hbN/Pa5Y9DfpFLLOtgbqPPobYspZRC+UJPosF6miELppa+tUZIVzdRId?= =?Windows-1252?Q?X713UsQBB4JvuxFfEXXtJknu9G68EXSw8QcVqlkOq1QwwjBvXJojaCpn?= =?Windows-1252?Q?sRlOotbmvFWHljjIeg3nBrIgvKIDM6Rk+SQeCZ3U0eCNu0m6ElX/ifMR?= =?Windows-1252?Q?M7z2X/6i+BDqRRoA+pLGknYU2MyVH50teDZHj7tdCKYHc2PD76B5t42u?= =?Windows-1252?Q?rqSVfOxvLK4r8j9pKqkJN/bxaRPabkyL8OHLexQJjZLOOQM1RyKcBVYY?= =?Windows-1252?Q?5SZDKeI6pnjBL+M5kguMoW0UVxVhXeNsxR1mEaZNfphKK2q4bTxo3Fsj?= =?Windows-1252?Q?7j7GdELerVYoDkzsi9FTqpHhL4iwauEiirbluSwHpzkCVqw+w88bKMcc?= =?Windows-1252?Q?O6QzPgGOHcNqwC1/gg/zcK8BeXowt7PSUFi2N1hI6KLynGiI+wgTtIkn?= =?Windows-1252?Q?GzzO1amkHvRrHD24mdqIOpcem57qLdoI14Pn/nW/erAVdhnsxDMrTuP8?= =?Windows-1252?Q?CF7cgolRur98TjJFaN0uniqNPkqaPfHbOfOh38mWFrXfqTHBq+J4isC5?= =?Windows-1252?Q?GB0Uhzc2a5LoPcv91a2ec0LR9spQBRjP5uoRLCNdPMx12EIJL4egb5wT?= =?Windows-1252?Q?9+1SfPFKe31Iud5vm/c3Snr+1iqQ+HI1g=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;6:Gmng4ZVNYoFi+B5gkPgjMiVLUXjanhPYXyYoCNUQlwGVKFu+Ys2LVqd5BrIIUqSvk/+84KgkbxmK25OIXlPHMvE1SR49HvUXFubd2mFGsVzRhz5ywwiqx+F/agh9lPNwFi97k5eTYge8APiSd2bNvCnHCHYuRif3QU6yn9an2VlkLXJUbiHpCBmzR7DgRri4Str9ZgEfLqK7IjPye7ZGRcFhgYiiUrjIGd1SePGrPcj0OYlDnrptIz5/36v/E0plxAGedg67ktZBLs4v68GW0lZMxabC8zBoNwUAPFA2v6yn3+NBW6VLBJhZ/jeehhD+3Qh9J+JVqq+oqaJh5k7MQKTMCWaz3z7oV9YUNBs+n1U=;5:rZ+j3nPNLsDVUHk1xUK84OFlHCFjb4ZH1ogRQwb/+463M80qEFERas+r3SRPNxwL8V3QrBFlqupPso9RZAkQwEXt5YGexPHh2g1dZy0ZNMoZf8EJnkfyupFKr7+omJ/7LytgiWRxCh8GYxEnA51GQFwfr8B8C6a66U5Jndb0DzU=;24:iREttfcv4RSihnz3wULkAUYib8DrD6AjQnNAp+LXjVp90yb+XoIvRD+ztCCtild8tDRXo1UbHlhnufgluiJtmshbmBHIjqcey/3Ss4U0bAc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;7:VrRd63dQjp5rrZPHbl/Pq6zl7Totf5nJ7Cmj6Sur7f8JNQe+PTkVQSSpal0U4gmUXEq4Whle+E91BFIDWevwd2ud2j0N23iRFvj2LkloGkJUGQyQPc6UAuJVoAsVNlb02YNScDSVjILafRGN7nhCgtDv2cStTUBkc9rsT9WRzMXFxOqWXuoTFGRPCuef/QhiyXgq5fCm/lgS1GBATyfiopacbpP2xcs2sHOiwdW8V7zo9Kmjab1jVoxjkprUYUHs/HP/I3aGYEXOLvzDH+EjPhNcp2C0M9Ii9f+LKVy6N+4puyOv2UmqK6EOLuXS5DFq/pjS3sU0piRZpindogn45O1ph0E0esTUxbnBgZLWwGM=;20:/5zfj9AiFO0JMUapItbz3nNUTYo1RJ+2cDPg0x1MB8wyvZiHF7qgNjoqh521de6N8lJJiqNRVrHS4jdG+jtvoUBDFNL6YPNJpm23Zh7m3+TqVPQlwCuAUL7chmRPLCAACcEWqW2ZKga59z6Yv0y5UiFP9hUBYwwsfkSCh7Z7QP1e7WNiESl4TFEodK+v0Z8t5lTMVvdIJIZSjraS+dVnDI4Ga66efc/Oulfo5j2NnQ5Ddv2f89Pfoz2r+Oj44SO/ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2016 09:20:53.1086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 12.10.2016 um 08:17 schrieb Dan Carpenter: > debugfs_create_file() returns NULL on error, it only returns error > pointers if debugfs isn't enabled in the config and we checked for that > earlier so it can't happen. > > Fixes: 4f4824b55650 ('drm/amd/amdgpu: Convert ring debugfs entries to binary') > Signed-off-by: Dan Carpenter Reviewed-by: Christian König . > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > index 85aeb0a..8d16eaf 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > @@ -371,8 +371,8 @@ static int amdgpu_debugfs_ring_init(struct amdgpu_device *adev, > ent = debugfs_create_file(name, > S_IFREG | S_IRUGO, root, > ring, &amdgpu_debugfs_ring_fops); > - if (IS_ERR(ent)) > - return PTR_ERR(ent); > + if (!ent) > + return -ENOMEM; > > i_size_write(ent->d_inode, ring->ring_size + 12); > ring->ent = ent;