From: Dan Carpenter <dan.carpenter@linaro.org>
To: Akshay Gupta <akshay.gupta@amd.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
arnd@arndb.de, shyam-sundar.s-k@amd.com, gautham.shenoy@amd.com,
mario.limonciello@amd.com, naveenkrishna.chatradhi@amd.com,
anand.umarji@amd.com
Subject: Re: [PATCH v2 2/2] misc: amd-sbi: Address copy_to/from_user() warning reported in smatch
Date: Wed, 25 Jun 2025 14:43:35 +0300 [thread overview]
Message-ID: <0d18ed52-86cf-44a3-913a-d514f7b8d4a7@suswa.mountain> (raw)
In-Reply-To: <20250625110707.315489-2-akshay.gupta@amd.com>
On Wed, Jun 25, 2025 at 11:07:07AM +0000, Akshay Gupta wrote:
> Smatch warnings are reported for below commit,
>
> Commit bb13a84ed6b7 ("misc: amd-sbi: Add support for CPUID protocol")
> from Apr 28, 2025 (linux-next), leads to the following Smatch static
> checker warning:
>
> drivers/misc/amd-sbi/rmi-core.c:376 apml_rmi_reg_xfer() warn: maybe return -EFAULT instead of the bytes remaining?
> drivers/misc/amd-sbi/rmi-core.c:394 apml_mailbox_xfer() warn: maybe return -EFAULT instead of the bytes remaining?
> drivers/misc/amd-sbi/rmi-core.c:411 apml_cpuid_xfer() warn: maybe return -EFAULT instead of the bytes remaining?
> drivers/misc/amd-sbi/rmi-core.c:428 apml_mcamsr_xfer() warn: maybe return -EFAULT instead of the bytes remaining?
>
> copy_to/from_user() returns number of bytes, not copied.
> In case data not copied, return "-EFAULT".
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/all/aDVyO8ByVsceybk9@stanley.mountain/
> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
> Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
> ---
> Changes from v1:
> - Split patch as per Greg's suggestion
> drivers/misc/amd-sbi/rmi-core.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/misc/amd-sbi/rmi-core.c b/drivers/misc/amd-sbi/rmi-core.c
> index 3570f3b269a9..9048517c088c 100644
> --- a/drivers/misc/amd-sbi/rmi-core.c
> +++ b/drivers/misc/amd-sbi/rmi-core.c
> @@ -372,7 +372,8 @@ static int apml_rmi_reg_xfer(struct sbrmi_data *data,
> mutex_unlock(&data->lock);
>
> if (msg.rflag && !ret)
Unrelated to this patch, but it's always better to do if (ret) {.
Do error handling not success handling etc.
> - return copy_to_user(arg, &msg, sizeof(struct apml_reg_xfer_msg));
> + if (copy_to_user(arg, &msg, sizeof(struct apml_reg_xfer_msg)))
> + return -EFAULT;
> return ret;
> }
>
> @@ -390,7 +391,9 @@ static int apml_mailbox_xfer(struct sbrmi_data *data, struct apml_mbox_msg __use
> if (ret && ret != -EPROTOTYPE)
> return ret;
>
> - return copy_to_user(arg, &msg, sizeof(struct apml_mbox_msg));
> + if (copy_to_user(arg, &msg, sizeof(struct apml_mbox_msg)))
> + return -EFAULT;
> + return ret;
This fixes the -EPROTOTYPE as well. In the original code, it would
return success where -EPROTOTYPE was intended. It's probably worth
mentioning that in the commit message and maybe adding a test cases to
your test platform.
regards,
dan carpenter
next prev parent reply other threads:[~2025-06-25 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 11:07 [PATCH v2 1/2] misc: amd-sbi: Address potential integer overflow issue " Akshay Gupta
2025-06-25 11:07 ` [PATCH v2 2/2] misc: amd-sbi: Address copy_to/from_user() warning " Akshay Gupta
2025-06-25 11:43 ` Dan Carpenter [this message]
2025-06-30 11:32 ` Gupta, Akshay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d18ed52-86cf-44a3-913a-d514f7b8d4a7@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=akshay.gupta@amd.com \
--cc=anand.umarji@amd.com \
--cc=arnd@arndb.de \
--cc=gautham.shenoy@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=shyam-sundar.s-k@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®