From: Jakob Hauser <jahau@rocketmail.com>
To: Henrik Grimler <henrik@grimler.se>
Cc: Sebastian Reichel <sre@kernel.org>, Lee Jones <lee@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Beomho Seo <beomho.seo@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Stephan Gerhold <stephan@gerhold.net>,
Raymond Hackley <raymondhackley@protonmail.com>,
Pavel Machek <pavel@ucw.cz>, Axel Lin <axel.lin@ingics.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v3 8/8] dt-bindings: Add rt5033 mfd, regulator and charger
Date: Fri, 28 Apr 2023 17:42:50 +0200 [thread overview]
Message-ID: <0d20da8a-3d25-7164-65c0-a6f5763473e8@rocketmail.com> (raw)
In-Reply-To: <ZEvaixFJGk/Nr1m2@L14.lan>
Hi Henrik,
On 28.04.23 16:39, Henrik Grimler wrote:
> On Fri, Apr 28, 2023 at 01:30:11AM +0200, Jakob Hauser wrote:
...
>> + regulators:
>> + description:
>> + The regulators of RT5033 have to be instantiated under a sub-node named
>> + "regulators". For SAFE_LDO voltage there is only one value of 4.9 V. LDO
>
> Is only 4.9 V valid for SAFE_LDO? If I am reading driver found in
> vendor kernel for SM-A500F it seems to to allow values between 3.3 and
> 4.95 V [1]. Same range is also written in the devicetree for the
> device [2].
>
> [1] https://github.com/msm8916-mainline/linux-downstream/blob/SM-A500F/drivers/regulator/rt5033_regulator.c#L109-L114
> [2] https://github.com/msm8916-mainline/linux-downstream/blob/SM-A500F/arch/arm/boot/dts/samsung/msm8916/msm8916-sec-a5u-eur-r01.dtsi#L148-L149
>
You're right, the RT5033 regulator SAFE_LDO is capable of more than one
voltage.
In the mainline rt5033-regulator driver, however, for SAFE_LDO only the
one voltage at 4.9 V is implemented so far.
https://github.com/torvalds/linux/blob/v6.3/include/linux/mfd/rt5033-private.h#L211-L212
https://github.com/torvalds/linux/blob/v6.3/drivers/regulator/rt5033-regulator.c#L83
For the charger driver this seems sufficient.
Kind regards,
Jakob
next prev parent reply other threads:[~2023-04-28 15:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1682636929.git.jahau.ref@rocketmail.com>
2023-04-27 23:30 ` [PATCH v3 0/8] Add RT5033 charger device driver Jakob Hauser
2023-04-27 23:30 ` [PATCH v3 1/8] mfd: rt5033: Drop rt5033-battery sub-device Jakob Hauser
2023-04-27 23:30 ` [PATCH v3 2/8] mfd: rt5033: Fix chip revision readout Jakob Hauser
2023-04-27 23:30 ` [PATCH v3 3/8] mfd: rt5033: Fix STAT_MASK, HZ_MASK and AICR defines Jakob Hauser
2023-04-27 23:30 ` [PATCH v3 4/8] mfd: rt5033: Apply preparatory changes before adding rt5033-charger driver Jakob Hauser
2023-04-27 23:30 ` [PATCH v3 5/8] power: supply: rt5033_charger: Add RT5033 charger device driver Jakob Hauser
2023-05-05 11:51 ` Linus Walleij
2023-04-27 23:30 ` [PATCH v3 6/8] power: supply: rt5033_charger: Add cable detection and USB OTG supply Jakob Hauser
2023-04-27 23:30 ` [PATCH v3 7/8] power: supply: rt5033_battery: Adopt status property from charger Jakob Hauser
2023-04-27 23:30 ` [PATCH v3 8/8] dt-bindings: Add rt5033 mfd, regulator and charger Jakob Hauser
2023-04-28 14:39 ` Henrik Grimler
2023-04-28 15:42 ` Jakob Hauser [this message]
2023-05-01 7:21 ` Krzysztof Kozlowski
2023-05-01 17:35 ` Jakob Hauser
2023-05-01 21:16 ` Jakob Hauser
2023-05-02 10:59 ` Krzysztof Kozlowski
2023-05-03 19:33 ` Jakob Hauser
2023-05-05 20:13 ` Rob Herring
2023-05-06 10:48 ` Jakob Hauser
2023-05-01 9:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d20da8a-3d25-7164-65c0-a6f5763473e8@rocketmail.com \
--to=jahau@rocketmail.com \
--cc=axel.lin@ingics.com \
--cc=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®