From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AC272AD2A for ; Fri, 20 Dec 2024 03:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734664764; cv=none; b=gRLZad5MldFZICHAvWiPOfJvQ8t+dCA/6Hs+dcCkUBTzbsnh2e4FOGYM4d8od3fDQw4pqmq1ZGEC39417uzOb6zlL6sRR99GKSlMtYB+YtSIR2XTtF9bL2oKQ8iOyMTCTHj/7JCAqRpqktc4tPfV36a8g2432TaDrsmlgCkGvCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734664764; c=relaxed/simple; bh=uCgBGgTkD5WTJc0PbW6t6yd28OqtFubn7vs10z3cGgM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=av2dzYiov1O7CeRKv7dOvCo0vjgNYgY309wG9A2FfSANz9b0oJ/+u4ekjkJ2n1tB1ZNnX2Xkcg5Z3KXgdy46DiuTN9Cw9PpAnq0xcB42slLH/xTviK2qFuYjma4wa6vuDxxSDiVl+0lwgbHsvyw78yFN5f22Np9lQKTg9g1yZ2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=O4Vx/XMN; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="O4Vx/XMN" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2166f1e589cso16044445ad.3 for ; Thu, 19 Dec 2024 19:19:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734664761; x=1735269561; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=51Bci1H5mL9OOnwiHpY7i+lv4oTBv7dl4EI7SLg4wXo=; b=O4Vx/XMNYfOocZILMG7r2gjGNmLBfL67x9UYuoXWFrfommjSujjw1LntCQzBhXMLjn M1ccVVtqf0JeWpXkGW8LNXOdSWG8D5xNyWB8QEvOFvkdcLaqjv8ciaiir9nO+r4yTWyS 9a12xmSazhnbYhnFrWftl5igVcZ1SbhXP2fvrog7I/iacYdiRe+v05UjWlpeb/zjzV3d VaYgZbEZ7F843PR6PYxcRr9g8J99jehuQXK4mip4kH1E3U9fKmQzRQPzNvl52aNUvni0 zxUFHGDMHobkRWQ2TP9zuasgUZKC76kYQu3d3XT9i95E0jAWVLxv5p1bdijft6W7f+/u W+nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734664761; x=1735269561; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=51Bci1H5mL9OOnwiHpY7i+lv4oTBv7dl4EI7SLg4wXo=; b=nrpFY/JIh+efOwawVP6AYtzbsBpeoQzLgSO4KsDNydg/aMbUJhZQZyP81DIY+hcew4 aKnDtSzm8KDs/79XHImwVJXD7DZNbleELRoElfBjMBLSdDOTYBwzNR/Z2zjZFqOj05ol J5doaNgqpNjiynkAuxwaNnKbiRlb3hLPkpUWnFRflkOxMCGpZTzh3spEjSlNX1nBMeYB 6Mf2WUCRrFYDl00/fxXXA97pDE9RP/FRPNUJVzbesLRwGlM6J4Nczy00bnANb38cdO7E ywE7ELBxbaDkkO9YUb9bmFhy5rLyocpYmpzaORU8FPv+zAp6fK8yCj5D8477cKNkgkUi 6vjA== X-Forwarded-Encrypted: i=1; AJvYcCV5a67Pd40TtDNHHV0B33X9T8xiCUc5Klb1PGKzXOmpJFUfxZA/djskGC/0prhTxED9btKtLHkvajedtSE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/eQYRMfM/oSImgpaFnalXcLnGm6rc0T2hReFVU2S8IniFMkUY 30GWEt6KGw17BkkLm5BES2DKeW5gFLA9UDyeY0zOS4xo6RNWzab5DtanmgE37MU= X-Gm-Gg: ASbGncv8niKsNszIIqmTWqUsC8QPp1s8C50N9GQdCwPRk9yfnTyveVkAlMLCjEkOR99 y6w+nn5wKizm6JZQ1OqFVnT8sWlY3iBYbtr9mLMu/Q/rI2DdHjQImT6qi5JRdotcPytdic0DL7K 8DtoNHS8noRobkEPpRFAW7PbNZoP8Gu5e0UQQmXiBo73tagox6sQl/KbMFMAK1yRDlm6AA5PLGd U+YcdXi2cYkby4m2NRlWyeAAK6m5ePK0yBvjOW/rLjyHpAbs0gNF+fRPpWaW8QyDYEhGuRDHZBp SuNlpQ== X-Google-Smtp-Source: AGHT+IE/Lwl6AERlnJfBgHbvf0mEOu0EDQNE/8CDgO2tsd4ItkTJiY/nI3OxlMpfKGheClOtH0QPfA== X-Received: by 2002:a17:903:24e:b0:216:1cfa:2bda with SMTP id d9443c01a7336-219e6f25fbamr16680525ad.43.1734664761307; Thu, 19 Dec 2024 19:19:21 -0800 (PST) Received: from [10.4.194.102] ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96eae7sm19615015ad.85.2024.12.19.19.19.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 19:19:20 -0800 (PST) Message-ID: <0d22a66a-8c35-40f2-be1c-0a4a94885d9a@bytedance.com> Date: Fri, 20 Dec 2024 11:19:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/15] mm: pgtable: introduce generic p4d_alloc_one() and p4d_free() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Alexander, On 2024/12/20 00:32, Alexander Gordeev wrote: > On Wed, Dec 18, 2024 at 09:04:38PM +0800, Qi Zheng wrote: >> For these architectures, provide a generic implementation in >> asm-generic/pgalloc.h and convert them to use it. And like other levels >> of page tables, add statistics for P4D level page table. > > FWIW, introducing the generic implementation and adding ctor|dtors > look as separate changes to me. OK, will separate it in v3. > > ... >> static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d) >> { >> - if (!pgtable_l5_enabled()) >> - return; >> - BUG_ON((unsigned long)p4d & (PAGE_SIZE-1)); > > Or maybe? > > BUG_ON(!IS_ALIGNED((unsigned long)p4d, PAGE_SIZE)); Do you mean to keep BUG_ON() and change it to the above form? I would prefer to just drop BUG_ON() as is done with the other page tables. Thanks, Qi > >> - free_page((unsigned long)p4d); >> + if (pgtable_l5_enabled()) >> + __p4d_free(mm, p4d); >> }