From: Chris Wilson <chris@chris-wilson.co.uk>
To: Felipe Balbi <balbi@ti.com>, linux-kernel@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: fixup headers_check
Date: Sun, 16 Jan 2011 11:07:32 +0000 [thread overview]
Message-ID: <0d30dc$kp159h@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1295174783-4099-1-git-send-email-balbi@ti.com>
On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi <balbi@ti.com> wrote:
> Drop the following headers_check errors:
> /linux-2.6/usr/include/drm/drm_mode.h:85: found
> __[us]{8,16,32,64} type without #include <linux/types.h>
> /linux-2.6/usr/include/drm/i915_drm.h:120: found
> __[us]{8,16,32,64} type without #include <linux/types.h>
> /linux-2.6/usr/include/drm/mga_drm.h:260: found
> __[us]{8,16,32,64} type without #include <linux/types.h>
> /linux-2.6/usr/include/drm/radeon_drm.h:758: found
> __[us]{8,16,32,64} type without #include <linux/types.h>
> /linux-2.6/usr/include/drm/via_drm.h:117: found
> __[us]{8,16,32,64} type without #include <linux/types.h>
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> include/drm/drm_mode.h | 2 ++
> include/drm/i915_drm.h | 1 +
> include/drm/mga_drm.h | 1 +
> include/drm/radeon_drm.h | 1 +
> include/drm/via_drm.h | 1 +
> 5 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> index 0fc7397..1678d7b 100644
> --- a/include/drm/drm_mode.h
> +++ b/include/drm/drm_mode.h
> @@ -27,6 +27,8 @@
> #ifndef _DRM_MODE_H
> #define _DRM_MODE_H
>
> +#include <linux/types.h>
> +
Would
#if 0
#include <linux/types.h> /* silence make header_check */
#endif
be an acceptable compromise?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-01-16 11:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 10:46 Felipe Balbi
2011-01-16 10:46 ` [PATCH 2/2] arm: omap: remove duplicated headers Felipe Balbi
2011-01-16 18:00 ` Paul Walmsley
2011-01-16 10:47 ` [PATCH 1/2] drm: fixup headers_check Felipe Balbi
2011-01-16 11:07 ` Chris Wilson [this message]
2011-01-16 11:16 ` Felipe Balbi
2011-01-16 11:18 ` Felipe Balbi
2011-01-16 11:42 ` Dave Airlie
2011-01-16 12:23 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$kp159h@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=balbi@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®