From: Chris Wilson <chris@chris-wilson.co.uk>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Dont kick-off hangcheck after a DRI interrupt
Date: Thu, 20 Jan 2011 11:00:25 +0000 [thread overview]
Message-ID: <0d30dc$kqbkiv@orsmga001.jf.intel.com> (raw)
In-Reply-To: <20110120101010.GA4299@gondor.apana.org.au>
On Thu, 20 Jan 2011 21:10:10 +1100, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> While the current kernel tree has indeed changed from 2.6.36,
> I don't think this is the spot corresponding to my crash.
>
> My spot was in hangcheck_elapsed and as far as I can see it will
> crash in the current kernel in pretty much the same way. In
> particular, i915_hangcheck_ring_idle will probably crash on all
> three rings.
Except that i915_hangcheck_elapsed should not be called from DRI code
paths, the whole error recovery code only works with GEM (we can't recover
the hardware if it is being poked directly by "userspace").
> FWIW after adding the INIT_LIST_HEAD to the init_dri function
> my kernel hasn't crashed yet (a couple of hours and counting).
Ah, yes. Need to pull some more code in from init_ringbuffer.
For my sanity can you check that the above patch also prevents the crash?
I'd rather not install a timer, and execute undesirable code paths, if we
don't need one.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-01-20 11:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 11:57 i915 completely broken with KMS off Herbert Xu
2011-01-18 17:16 ` Jesse Barnes
2011-01-18 17:24 ` [PATCH] drm/i915: Correctly test for an initialised ring for dri1 Chris Wilson
2011-01-19 3:24 ` Herbert Xu
2011-01-19 9:53 ` [PATCH] drm/i915: Initialise ring vfuncs for old DRI paths Chris Wilson
2011-01-19 10:31 ` Herbert Xu
2011-01-20 7:05 ` Herbert Xu
2011-01-20 9:56 ` [PATCH] drm/i915: Don't kick-off hangcheck after a DRI interrupt Chris Wilson
2011-01-20 10:10 ` Herbert Xu
2011-01-20 11:00 ` Chris Wilson [this message]
2011-01-20 11:35 ` [PATCH] drm/i915: Dont " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$kqbkiv@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=herbert@gondor.hengli.com.au \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome