From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754487AbeARABo (ORCPT ); Wed, 17 Jan 2018 19:01:44 -0500 Received: from merlin.infradead.org ([205.233.59.134]:40748 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753688AbeARABm (ORCPT ); Wed, 17 Jan 2018 19:01:42 -0500 Subject: Re: [PATCH] input: joystick: make USB drivers depend on USB To: Dmitry Torokhov , Marcus Folkesson Cc: Tomohiro Yoshidomi , David Herrmann , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180117213010.810-1-marcus.folkesson@gmail.com> <20180117215316.7qe5o2pspb3dqgny@dtor-ws> From: Randy Dunlap Message-ID: <0d326efa-9134-d515-973e-791919f478f0@infradead.org> Date: Wed, 17 Jan 2018 16:01:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180117215316.7qe5o2pspb3dqgny@dtor-ws> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: >> A driver should not enable an entire subsystem. > > I disagree. As you go through menuconfig and you encounter this option > and you have the hardware and you want to enable it, you should be able > to do so. Otherwise you enable bunch of functionality, then go back, > see what new options appeared, enable them, go back, see if any more new > options appeared, and so on. > > What exactly prompted this change? Two things: today when I reviewed Marcus's patch that selected USB, I commented something along that line. But that was based on something that Linus has written at least two times in the past on lkml. >> >> Signed-off-by: Marcus Folkesson >> --- >> drivers/input/joystick/Kconfig | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig >> index 332c0cc1b2ab..4a199cff8c68 100644 >> --- a/drivers/input/joystick/Kconfig >> +++ b/drivers/input/joystick/Kconfig >> @@ -279,8 +279,7 @@ config JOYSTICK_JOYDUMP >> >> config JOYSTICK_XPAD >> tristate "X-Box gamepad support" >> - depends on USB_ARCH_HAS_HCD >> - select USB >> + depends on USB >> help >> Say Y here if you want to use the X-Box pad with your computer. >> Make sure to say Y to "Joystick support" (CONFIG_INPUT_JOYDEV) >> -- -- ~Randy