From: Guenter Roeck <linux@roeck-us.net>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>
Cc: "jdelvare@suse.com" <jdelvare@suse.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"Verdun, Jean-Marie" <verdun@hpe.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/6] ABI: sysfs-class-hwmon: add a description for fanY_fault
Date: Tue, 29 Nov 2022 08:38:26 -0800 [thread overview]
Message-ID: <0d32c71c-9d88-26fe-60a3-e13ff64a47ad@roeck-us.net> (raw)
In-Reply-To: <0A5DF9D5-B8C2-44A4-924A-B8957EC8A2A7@hpe.com>
On 11/29/22 08:15, Hawkins, Nick wrote:
>> This change is really completely unrelated to a CPLD or specific SoC.
>> The commit description is just confusing. It should simply state that
>> it documents the existing fanX_fault attribute.
>
> Understood. Just to confirm should I change fanY_fault to fanX_fault
> in documentation as well as the patch description? For instance:
> /sys/class/hwmon/hwmonX/fanX_fault
>
> It seems that the documentation around it uses fanY_ format.
>
Now you start splitting hairs ;-). I wanted to point out that
fan[X,Y,Z,A,B,C,...]_fault is a generic attribute, not that I want you
to change fanY to fanX.
Guenter
next prev parent reply other threads:[~2022-11-29 16:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 23:02 [PATCH v2 0/6] ARM: Add GXP Fan and SPI controllers nick.hawkins
2022-11-28 23:02 ` [PATCH v2 1/6] hwmon: (gxp-fan-ctrl) Add GXP fan controller nick.hawkins
2022-11-29 4:02 ` Guenter Roeck
2022-11-29 17:13 ` Hawkins, Nick
2022-11-29 18:26 ` Guenter Roeck
2022-11-29 6:58 ` kernel test robot
2022-11-28 23:02 ` [PATCH v2 2/6] ABI: sysfs-class-hwmon: add a description for fanY_fault nick.hawkins
2022-11-29 3:34 ` Guenter Roeck
2022-11-29 16:15 ` Hawkins, Nick
2022-11-29 16:38 ` Guenter Roeck [this message]
2022-11-28 23:02 ` [PATCH v2 3/6] dt-bindings: hwmon: Add hpe,gxp-fan-ctrl nick.hawkins
2022-11-28 23:02 ` [PATCH v2 4/6] ARM: dts: add GXP Support for fans and SPI nick.hawkins
2022-11-28 23:02 ` [PATCH v2 5/6] ARM: multi_v7_defconfig: Add GXP Fan and SPI support nick.hawkins
2022-11-28 23:02 ` [PATCH v2 6/6] MAINTAINERS: add gxp fan controller and documents nick.hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d32c71c-9d88-26fe-60a3-e13ff64a47ad@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®